EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.58k stars 333 forks source link

crossfire 6.19 will not work at 400k #3688

Closed ror1948 closed 1 year ago

ror1948 commented 1 year ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

TX16x with edgetx-firmware-nightly-ba56166f TBS micro Crossfire module V2 with 6.19 and TBS crossfire nano Rx pro unable to bind with a baudrate of 400k. It binds at 115K but the output map never populates in the Lua script. Using LUA script TBS Agent Lite 0.96

Expected Behavior

bind with baudrate at 400k

Steps To Reproduce

Tx(micro Tx module V2 installed in bay) Press MDL Press External RF Select baudrate 400k Press RTN several times press SYS button select TBS AGENT LITE Lua script Select Tx module Select bind

Version

Nightly (Please give date/commit below)

Transmitter

Radiomaster TX16S / TX16SMK2

Operating System (OS)

No response

OS Version

No response

Anything else?

edgetx-firmware-nightly-ba56166f

ror1948 commented 1 year ago

works as expected with edgetx 2.8.4

pfeerick commented 1 year ago

I should be able to test this myself also in about two weeks as will be getting a crossfire set then.

ror1948 commented 1 year ago

thanks


From: Peter Feerick @.> Sent: Sunday, June 18, 2023 10:53 PM To: EdgeTX/edgetx @.> Cc: ror1948 @.>; Author @.> Subject: Re: [EdgeTX/edgetx] crossfire 6.19 will not work at 400k (Issue #3688)

I should be able to test this myself also in about two weeks as will be getting a crossfire set then.

— Reply to this email directly, view it on GitHubhttps://github.com/EdgeTX/edgetx/issues/3688#issuecomment-1596414028, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXSV3BYDYF75J7I3HJF3TADXL65MBANCNFSM6AAAAAAZKMC2KQ. You are receiving this because you authored the thread.Message ID: @.***>

3djc commented 1 year ago

Cannot reproduce (compiled main as of today):

image

image

image

pfeerick commented 1 year ago

Not so fast... there's two parts to this JC 😆

It binds at 115K but the output map never populates in the Lua script.

He wasn't able to bind at 400k, but was at 115k, but then can't do channel/output remapping in the Lua (not sure at what baud rate - it will probably never work at 115k).

works as expected with edgetx 2.8.4

Was that @ 400k baud rate?

3djc commented 1 year ago

like so ?

image

pfeerick commented 1 year ago

That's the one :)

3djc commented 1 year ago

All changed (but I guess I should not try to use the receivere configured like that !!!!)

image

pfeerick commented 1 year ago

Wait a minute... are you using the old Crossfire lua for that? What about the TBS AGENT LITE Lua script (0.96 atm) referenced ;)

Even so, I can't repo this with TBS Agent Lite 0.96 and Tracer on 6.19, 400k, TX16S (mk 1) with currently nightly. I was able to the last time this was raised though. Both the output mapping and channel mapping screens take several seconds to load, but it does load, and the progress bar works its way across while loading...

image image image

3djc commented 1 year ago

image

image

ror1948 commented 1 year ago

What is your RM version?

ror1948 commented 1 year ago

Yes all worked at 400k with 2.8.4At 115k output map never populated .But it bound ok.

3djc commented 1 year ago

All done at 400k, binding and all those screenshots

ror1948 commented 1 year ago

my CF Tx info CF-TX-micro

JimB40 commented 1 year ago

Reflash CRSF microTX with same 6.19 and chceck if problem still exist

ror1948 commented 1 year ago

will do does the version of boot loader matter? i am using boot loader 2.8.0


From: Robert @.> Sent: Monday, June 19, 2023 12:11 PM To: EdgeTX/edgetx @.> Cc: ror1948 @.>; Author @.> Subject: Re: [EdgeTX/edgetx] crossfire 6.19 will not work at 400k (Issue #3688)

Reflash CRSF microTX with same 6.19 and chceck if problem still exist

— Reply to this email directly, view it on GitHubhttps://github.com/EdgeTX/edgetx/issues/3688#issuecomment-1597445747, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXSV3BZOJYSH5YXGTOA6CELXMB24PANCNFSM6AAAAAAZKMC2KQ. You are receiving this because you authored the thread.Message ID: @.***>

ror1948 commented 1 year ago

OK good news

reflashed Tx with 6.19 Flashed RM with bootloader 2.9.0 Flashed RM with nightly Jun 18 2023

set at 400k baudrate

IT ALL WORKS fine CRSF Rx output map etc populates quickly

Thanks to all

OK to close this issue


From: Robert @.> Sent: Monday, June 19, 2023 12:11 PM To: EdgeTX/edgetx @.> Cc: ror1948 @.>; Author @.> Subject: Re: [EdgeTX/edgetx] crossfire 6.19 will not work at 400k (Issue #3688)

Reflash CRSF microTX with same 6.19 and chceck if problem still exist

— Reply to this email directly, view it on GitHubhttps://github.com/EdgeTX/edgetx/issues/3688#issuecomment-1597445747, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXSV3BZOJYSH5YXGTOA6CELXMB24PANCNFSM6AAAAAAZKMC2KQ. You are receiving this because you authored the thread.Message ID: @.***>

pfeerick commented 1 year ago

Damn... that really is quite annoying... it's intermittent bugs/problems like this that are the most frustrating. Fingers crossed it behaves now! :)

JimB40 commented 1 year ago

@pfeerick just to recap as this issue pops up frequently wit CRSF

  1. "115k and output not loading". Output channeles page have a lot of data 'behind'. One output option needs 3-4 CRSF chunk frames. Other features needs just 1 often. So with 115k which is too slow timeout is thrown because all chunks can't be read. Typical behavior of TBS Agent or Crossfire LUA with too low speed.

  2. "Can't connect with 400k" That is more puzzling. This re-flash (refresh) tbs firmware is old trick I've learned writing Agent. Not sure why it behaves like that. But it seems flashing process is not 101% proof. Nevetheles with serial there are two parties that talk and few weeks ago we had some bug in etx fw that caused problems with CRSF. Seems it is gone now with latest nighlty.

ror1948 commented 1 year ago

it may have been the bootloader version that i was using? i was using 2.8.0 when i had the problem now 2.9.0 and it is working.

maybe?


From: Robert @.> Sent: Monday, June 19, 2023 11:44 PM To: EdgeTX/edgetx @.> Cc: ror1948 @.>; Author @.> Subject: Re: [EdgeTX/edgetx] crossfire 6.19 will not work at 400k (Issue #3688)

@.***https://github.com/pfeerick just to recap as this issue pops up frequently wit CRSF

  1. "115k and output not loading". Output channeles page have a lot of data 'behind'. One output option needs 3-4 CRSF chunk frames. Other features needs just 1 often. So with 115k which is too slow timeout is thrown because all chunks can't be read. Typical behavior of TBS Agent or Crossfire LUA with too low speed.

  2. "Can't connect with 400k" That is more puzzling. This re-flash (refresh) tbs firmware is old trick I've learned writing Agent. Not sure why it behaves like that. But it seems flashing process is not 101% proof. Nevetheles with serial there are two parties that talk and few weeks ago we had some bug in etx fw that caused problems with CRSF. Seems it is gone now with latest nighlty.

— Reply to this email directly, view it on GitHubhttps://github.com/EdgeTX/edgetx/issues/3688#issuecomment-1598064542, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXSV3B7T5LRDFVSPJLBR7QTXMEMA7ANCNFSM6AAAAAAZKMC2KQ. You are receiving this because you authored the thread.Message ID: @.***>

JimB40 commented 1 year ago

You did both at the same time so we can't pin point. You can flash back 2.8.0 bootloader (as this is 10 sec task) and check. But I'd bet on CRSF FW reflash.

kamik2 commented 1 year ago

https://github.com/EdgeTX/edgetx/issues/3688#issuecomment-1598064542

there are a few posts on facebook etc with the same issue. for some, it loses binding after power cycling the radio on the next day, and some loose binding mid-flight/ ion the ground after some time. when those people flash their radio back to an older etx version or opentx, the issue is instantly fixed.

to me, it sounds like the model id gets lost/changed with some unknown trigger

ror1948 commented 1 year ago

I did an update to nightly on a friend’s TX16S and it worked at 400k. I updated bootloader to 2.9.0 and nightly jun18 2023

On Jun 19, 2023, at 23:54, Robert @.***> wrote:

You did both at the same time so we can't pin point. You can flash back 2.8.4 bootloader (as this is 10 sec task) and check. But I'd bet on CRSF FW reflash.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

pfeerick commented 1 year ago

to me, it sounds like the model id gets lost/changed with some unknown trigger

The model id should not change unless you 1) change models (and the new model has a different model id), or 2) change the id manually (or possibly via a Lua script? - but in that case, it's self-inflicted). There is an edge case when switching models with some RF modules, whereby the the model ID is sent before the transmitter module is ready, but this would only result in no connection to the receiver (unless it's id is 0). If you power cycled the radio, or set the model id again once changing models (i.e. change it to something else, and then change it back), it should reconnect instantly.

Outside of these specific cases, I would instead be suggesting there is a bug in the TBS firmware somewhere.

Ddraig62SPD commented 1 year ago

Thx for the insight & recommendations guys. Have just migrated from OpenTx 2.3.15 and was getting the exact same issue on all my X9D models. Running V2.8.4 Edge, V6.19 V1/V2 TX, V6.19 Nano RX. Reflashed the V6.19 CRSF V2 TX f/w then set 400K baud. Binds were all good and both Output & Channel maps are now displayed in the V0.96 TBS Agent Lite LUA. Much obliged :)

Edit: Likewise, reflashing V6.19 for the CRSF V1 TX model resolved the same OpenTx-->EdgeTx post-migration issue.

kamik2 commented 1 year ago

Outside of these specific cases, I would instead be suggesting there is a bug in the TBS firmware somewhere.

that was just an idea why some users could have experienced this issue. - even it would be super weird. they all had in common, that they switched to etx/ the latest public version of etx, with no update on the crossfire/tracer fw.

so far I could not reproduce these issues with my old x9d+ on any crossfire fw which makes the bug hunting extremely hard.

ror1948 commented 1 year ago

Take note the last guy switched to 2.8.4 and had the problem.He reprogrammed  TBS TX and all is well.