EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.59k stars 338 forks source link

2.9 - When writing the firmware on external module sentence is wrong #3695

Closed robustini closed 1 year ago

robustini commented 1 year ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

I just noticed today that when I write the firmware of the FrSky R9M module with ELRS during the flash at the bottom the words "module reset" remains even while writing as seen in the image, when it should only appear initially and then write "writing in progress".

Expected Behavior

It should do what I wrote above, I tried it with an older EdgeTX firmware (2.8) and in fact it works. I don't think the problem is in the language, IT is correct, here the two different sentences, the second one should appear while writing:

define TR_DEVICE_RESET "Resetto dispositivo..."

define TR_WRITING "Scrittura..."

Steps To Reproduce

  1. Flash the latest master (2.9)
  2. Write ELRS firmware to external module

Version

Nightly (Please give date/commit below)

Transmitter

FrSky X10 Express / X10S Express (ACCESS)

Operating System (OS)

Windows

OS Version

Windows 10 Pro x64

Anything else?

immagine

pfeerick commented 1 year ago

It's not unique to ELRS... it's the same for all. We'd noticed it before, but I didn't realise it was correct in 2.8, so will see what changed there - thanks for pointing that out! :)

It's been this way since around #3055 (or perhaps earlier - I just remember first seeing it around then). The STR_FLASH_DEVICE heading and STR_DEVICE_RESET is also delayed, probably until after the reset, so something else is going on there. This can also be seen on the simulator, there is mock code to allow that to behave the same as a real on-radio firmware update.

@philmoz Is this something you can look at? - I'm thinking it's mainly a GUI issue and is at least reproducible in simulator... it really should show the heading and "device reset" text first (while resetting), and then switch to "writing" once writing commences...

robustini commented 1 year ago

@pfeerick thanks Peter for your feedback. In the TX16S I have firmware compiled in November 2022, actually quite dated, and it works there.