search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.6k stars 339 forks source link

Unify the aux_serial compile options on all radios. #382

Open brainbubblersbest opened 3 years ago

brainbubblersbest commented 3 years ago

Also to prevent fragmenting the Code. The make file should be enough to differentiate between the different Models, everything else can be stay as an option

Please unify the Code for the aux Serials for All radios in the same way 1-On x10s / x12s the Bluetooth is not named as an Option in the make files and the hal leading to aux_serial2 is not available. So if compiling with flag -DBLUETOOTH=NO i can not use -DAUX_SERIAL2=YES

2-On x10s express or x10s x12s with externalaccessmod aux_serial1 is not available. This is ok.

But aux_serial1 on x10 and x12 Radios without express/access use of uart3 is only available with -DDEBUG=YES

I will test ollis mav link integration on that Radios. Unifiyng the way how the Serials are handled should be changed to make MAV-LINK possible like it is on the TX16S, the T18 and the T16.

A compile Option in future flasher releases like "BTisSERIALAUX1" can be used to make a Serial available, by removing the bt module as a Opt In.

@raphaelcoeffic is it already possible to built a bin for the x12 with the Changes you made in the mav-link integration branch?

brainbubblersbest commented 3 years ago

I just compiled a firmware for the x12 and x10 out of the mav-link branch. The cmake file in src/targets/horus just needs to changed from set BLUETOOTH ON TO option BLUETOOTH ON For x10 and x12

Maybe i should have better comment this in the mav-link branch authored by @raphaelcoeffic 😅 everything seems to work as it should 😁 testing....

raphaelcoeffic commented 3 years ago

This is just one part of the job. The other part would to unify the code implementing the serial ports, as it is a huge heap of copy-paste right now, located at 3-4 different places right now....

brainbubblersbest commented 3 years ago

As you done in the mav-link branch already. Or not? A year ago i searched for every change 3djc make to the Code to implementing the aux2_serial for the tx16s. I know this is not all it needs. Does it make any sense to leave this open because this already planned for the mav-link branch?

raphaelcoeffic commented 3 years ago

As you done in the mav-link branch already. Or not? A year ago i searched for every change 3djc make to the Code to implementing the aux2_serial for the tx16s. I know this is not all it needs. Does it make any sense to leave this open because this already planned for the mav-link branch?

I don’t mind either way.

brainbubblersbest commented 3 years ago

I can use AUX2_SERIAL ON X12S with the additional change described above.

brainbubblersbest commented 3 years ago

IMG_20210702_114804 IMG_20210702_114735

brainbubblersbest commented 3 years ago

The AUX_SERIAL (1) Is working with the Changes already made in the mav_link branch Testing the x12 with the mav_link branch now.