EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.63k stars 345 forks source link

throttle ESC not calibrated properly #3821

Open robb1364 opened 1 year ago

robb1364 commented 1 year ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Companion

Current Behavior

Hello, after installing latest version of Edge 2.8.4 my OMP HOBBY M2 stats to spin when the throttle is in about 13%. Before it wasn't also perfect but the value was lower I am not sure bt it could be like half of this. The procedure of calibrating the ESC which is normally used on other ESC like to rise the throttle to its maximum position and after initialization lower it to the lowest position doesn't work. I don't have other model on my radio so I can tell if it is problem of the Radiomaster TX16SII or the OMP HOBBY esc or the Edge. Can anyone help me to solve this problem please.

Expected Behavior

The throttle should be matched with ESC so that motor should start to spin in perfect condition in 1% increment.

Steps To Reproduce

It does it every time. Switch on and of the radio doesn't have any impact on it, nor calibration of the sticks.

Version

2.8.4

Transmitter

Radiomaster TX16S / TX16SMK2

Operating System (OS)

No response

OS Version

No response

Anything else?

No response

pfeerick commented 1 year ago

When you check the channel monitor on your transmitter, does it show throttle down as being -100% / 988us and throttle up as being 100% / 2012us? If so, the transmitter stick calibration is fine as such (it's outputting full range), and you need to either get throttle calibration working on the ESC or limit the values to what the ESC expects. For that, I would either use the weight and offset values for the throttle mix, or the min/max values on the outputs page. You could also use the Model Setup -> Throttle -> Trim idle only option so that you can use the throttle trim to tweak just the throttle value when the stick is low (i.e. effectively just tweaking the throttle stick down value)

Maybe @richardli can comment on this as I know he flies / follows the OMP heli stuff.

On Tue, Jul 18, 2023 at 5:50 PM robb1364 @.***> wrote:

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Companion Current Behavior

Hello, after installing latest version of Edge 2.8.4 my OMP HOBBY M2 stats to spin when the throttle is in about 13%. Before it wasn't also perfect but the value was lower I am not sure bt it could be like half of this. The procedure of calibrating the ESC which is normally used on other ESC like to rise the throttle to its maximum position and after initialization lower it to the lowest position doesn't work. I don't have other model on my radio so I can tell if it is problem of the Radiomaster TX16SII or the OMP HOBBY esc or the Edge. Can anyone help me to solve this problem please. Expected Behavior

The throttle should be matched with ESC so that motor should start to spin in perfect condition in 1% increment. Steps To Reproduce

It does it every time. Switch on and of the radio doesn't have any impact on it, nor calibration of the sticks. Version

2.8.4 Transmitter

Radiomaster TX16S / TX16SMK2 Operating System (OS)

No response OS Version

No response Anything else?

No response

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/3821, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ66KO6FSQP2VXAINZJF5LXQY54NANCNFSM6AAAAAA2N7QQI4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

robb1364 commented 1 year ago

Hello Peter,

First off all I am really impress about how quick you responded on both of my questions! (Second is about Jeti protocol)

Yes the throttle shows after calibration 100% on both sides and correct values 988us and 2012us. So I did it not the best way as I moved the lower point on my throttle curve as high as it is now about 3% lower when the motor start spinning and it works. May I have a question about the gimbals on the second version of the Radiomaster 16S? I have two peaces and one shows the resolution 3600 so it looks like it is more when 10 bit but less when 11 bit. As my moded old one with the FlySky gimbals shows 4046 I believe. The strange think is that the second one shows this value about 2500 which is little bit higher when 2048 which is 10 bit if I am correct but it is about 1000 less when the second one? In case you are interested I can send you pictures I made.

Kind regards

Robert

18. 7. 2023 v 10:09, Peter Feerick @.***>:

When you check the channel monitor on your transmitter, does it show throttle down as being -100% / 988us and throttle up as being 100% / 2012us? If so, the transmitter stick calibration is fine as such (it's outputting full range), and you need to either get throttle calibration working on the ESC or limit the values to what the ESC expects. For that, I would either use the weight and offset values for the throttle mix, or the min/max values on the outputs page. You could also use the Model Setup -> Throttle -> Trim idle only option so that you can use the throttle trim to tweak just the throttle value when the stick is low (i.e. effectively just tweaking the throttle stick down value)

Maybe @richardli can comment on this as I know he flies / follows the OMP heli stuff.

On Tue, Jul 18, 2023 at 5:50 PM robb1364 @.***> wrote:

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Companion Current Behavior

Hello, after installing latest version of Edge 2.8.4 my OMP HOBBY M2 stats to spin when the throttle is in about 13%. Before it wasn't also perfect but the value was lower I am not sure bt it could be like half of this. The procedure of calibrating the ESC which is normally used on other ESC like to rise the throttle to its maximum position and after initialization lower it to the lowest position doesn't work. I don't have other model on my radio so I can tell if it is problem of the Radiomaster TX16SII or the OMP HOBBY esc or the Edge. Can anyone help me to solve this problem please. Expected Behavior

The throttle should be matched with ESC so that motor should start to spin in perfect condition in 1% increment. Steps To Reproduce

It does it every time. Switch on and of the radio doesn't have any impact on it, nor calibration of the sticks. Version

2.8.4 Transmitter

Radiomaster TX16S / TX16SMK2 Operating System (OS)

No response OS Version

No response Anything else?

No response

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/3821, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ66KO6FSQP2VXAINZJF5LXQY54NANCNFSM6AAAAAA2N7QQI4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/3821#issuecomment-1639726821, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALJLNKQXLEJHCF6P42KO3EDXQZAEZANCNFSM6AAAAAA2N7QQI4. You are receiving this because you authored the thread.

pfeerick commented 1 year ago

Flysky gimbals are unusually high - 4096. There is also some oversampling going on with the analog gimbals which makes things different. However, on my TX16 I've also seen range of about 2926/1989 on one gimbal, and 1720/2720 on the other...

@rotorman Are you able to tell us why the raw readings are different that way? In my case, the above values are for the TX16S MK2, probably with V3 hall gimbals (or thereabouts, it's the dev one I was sent just before the MK2 was released 🤭 )

robb1364 commented 1 year ago

Hello, Peter do you think it hase sense to use the gimbals with higher range? From my radios I have the best pots, sliders and gimbal has Jumper T18 with ALPS RDC90, they are almost perfect both of them has 2048. But this radio is not as popular as Radiomaster. Thank you very much for your great support! Have a nice day

Robert

19. 7. 2023 v 3:50, Peter Feerick @.***>:

Flysky gimbals are unusually high - 4096. There is also some oversampling going on with the analog gimbals which makes things different. However, on my TX16 I've also seen range of about 2926/1989 on one gimbal, and 1720/2720 on the other...

@rotorman https://github.com/rotorman Are you able to tell us why the raw readings are different that way? In my case, it's the TX16S pre MK2 with probably V3 hall gimbals.

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/3821#issuecomment-1641265648, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALJLNKS7THC7UEXSKJGN26TXQ44NJANCNFSM6AAAAAA2N7QQI4. You are receiving this because you authored the thread.

rotorman commented 1 year ago

Raw reading differs indeed between analog gimbals and Flysky digital hall gimbals. The range one can expect from Flysky digital hall gimbals is ca. 4300 to 4500 digits, whereas on analog gimbals, the theoretical max with 12-bit ADC would be 4096, which is mostly never reached. Analog gimbals range is typically from 2500 to 3500, depending on the gimbal type/model used.

Please do note that if using present main branch (v2.10-dev), due to offset value change of PR #3778 code, Flysky digital hall gimbals NEED to be recalibrated, if they were calibrated previously with previous version of EdgeTX.