EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.64k stars 345 forks source link

Flysky CAT-01 still reporting erroneous values in 2.9RC1 #3847

Open dand3 opened 1 year ago

dand3 commented 1 year ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

Altitude/pressure values are way out by a very large amount Issue exist in 2.83 (see 2.83 -> PR#3583) but also 2.84 and now 2.9RC1 CAT01a-2023-07-22-2 9RC1

Hardware is TX16S - internal MPM mm-stm-serial-aetr-v1.3.3.20 / AFHDS2 Receiver Flysky FS-IA6B
Sensor is CAT-01 (* several sensors tested with same faulty results)

Expected Behavior

ETX 2.82 with same CAT-01 sensor is reporting altitude/pressure correctly CAT01a-2023-07-22-2 8 2

Steps To Reproduce

Load ETX2.8.2 is OK Load 2.8.3-2.8.4-2.9RC1 KO

Version

2.9.0

Transmitter

Radiomaster TX16S / TX16SMK2

Operating System (OS)

Windows

OS Version

No response

Anything else?

No response

dand3 commented 1 year ago

I volunteer for testing correcting software versiosn

pfeerick commented 1 year ago

I'll trigger the rebuild of a pr that was intended to fix this and let you know the id so can test it. It seemed mostly fine from when I tried it so some additional testing would be appreciated.

On Sun, 23 July 2023, 11:02 pm Dan, @.***> wrote:

Reopened #3847 https://github.com/EdgeTX/edgetx/issues/3847.

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/3847#event-9892741080, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ66KIHL3AON45ABNEVTJ3XRUOGJANCNFSM6AAAAAA2UMHNYQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

dand3 commented 1 year ago

Good new. Awaiting test version..

pfeerick commented 1 year ago

This is the PR I was thinking of : https://github.com/EdgeTX/edgetx/pull/3582. I've just rebased it, so it is basically what will be 2.9-RC2 + that change. Should be able to go to the Checks tab at the top of that PR, then click on "Run tests and package firmware" on the left side, and then click on "edgetx-firmware-merge" under the "Artifacts" heading to get the zip file with all the different firmware builds.

dand3 commented 1 year ago

TX16S loaded with ETX v2.10.0-PR3582 (ea7ce1fc) MPM mm-stm-serial-aetr-v1.3.3.20 Temp 21.5 °C Warmup time receiver & CAT01 sensor: 1 minute Number of measurement for each sensor: 3 (spaced in time) 4# pieces CAT01 tested '------------------------------------ Results are promising. Reported AGL altitude for all 4 sensors: #1=116m - #2=128m - #3=109m - #4=130m (One CAT01 sensor had a high t° drift and was took out of further test) Offset seems high, but can easily be compensated in "alt" telemetry settings or better via "Auto Offset" (both tested). A simple altitude test ( 1 floor) show's a 3.0 - 3.5m variation. Looks OK to me. Could be confirmed with a higher delta ( high building , lift etc.) or flight with double log (for example with FrSky High precision Alt/vario for comparison). Will try this later on. Big thanks to all dev's for the hard work done (and going on) ☺

CAT01 nr2-2023-07-25-v2 10 0-PR3582 CAT01 nr 2-2023-07-25- v2 10 0-PR3582 Auto Offset

CharlesGauci commented 1 year ago

I had completely given up on this issue and decided to keep my NV14 on version 2.8.2 and shelved my EL18 for the time being. Telemetry on internal module of the EL18 is a mess on all versions and not just with the FS-CAT01. I am not aware of any recent updates since I made this decision last April.

I cannot understand why Flysky decided to change the settings of the FS-CAT01 in version 2.8.3. If they stick to this decision, can anyone explain to us how to set up the telemetry screen?

I use voltage sensor FS-CVT01, temperature sensor FS-CTM01 and altitude sensor FS-CAT01 on all my models together with FS-IA6B and FS-IA10B receivers.

I previously mentioned these issues in pr and issue nos #3515 and #3583

pfeerick commented 1 year ago

Part of the problem with the FS-CAT01 is the iBUS processing is shared for both AFHDS 2A (NV14) and AFHDS3 (EL18) RF systems, and there seems to be some variance between how the two are handled. It was adjusted for the EL18, and verified against Flysky PL18 with stock firmware, but it cannonballed MPM and NV14 due to the AFHDS 2A being different.

i.e. using a single CAT-01 sensor throughout, on the PL18 with stock flysky firmware, it reports altitude as being roughly -138M for me... With 2.9.0-RC1, I get a similar reading on the EL18, and would need to use offset (or auto offset) to bring it back to 0 if I want to correct for relative ground level. If I switch over to NV14, it also shows -138-139 after a minute or two.

It's only when I get to the TX16S w/ MPM that Alt goes crazy... -1005m, Tmp2 is weird, Pressure seems to be updating way too fast and wrong. The aforementioned PR seemed to fix this for the MPM, without affecting the other radios. Hence the tests done above are very much appreciated to confirm that it seems to be the case still. There was just an issue outstanding for the FRM303 that if it still exists will need to be followed up separately.

richardclli commented 1 year ago

The altitude is now calculated via a table lookup with pressure measured and the definition is the altitude above the sea level.

Offset seems high, but can easily be compensated in "alt" telemetry settings or better via "Auto Offset" (both tested). A simple altitude test ( 1 floor) show's a 3.0 - 3.5m variation. Looks OK to me.

CharlesGauci commented 1 year ago

Testing version 2.9 RC2 Providence with FS-CAT01 on NV14 using FS-IA6B/FS-IA10B receivers, and EL18 using FTR10 receiver. NV14 : Seems to be working fine on Alt and Vspd vario, I will try it in the field next week EL18 : Alt keeps constantly changing values, I tried using Offset and Auto Offset but amounts keep on changing and do not seem to be responding to actual altitude changes. Vspd is still not included in the telemetry screen, I tried to create a copy of Alt, renamed it to Vspd and changed it to m/s, but it did not work.