EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.58k stars 336 forks source link

Companion Splash screen editor not able to apply image to firmware for BW Radio X9D 2019 #4352

Open craigywsm opened 10 months ago

craigywsm commented 10 months ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Companion

Current Behavior

When using companion 2.9.2 (not work on others either) I get and error "Compress image size exceeds reserved space" when trying to save the firmware when copying the image over and then saving the firmware. image

Expected Behavior

With the same image in other systems this works.

Steps To Reproduce

If I use the Settings--> Edit radio Splash Screen Left section I load the firmware from radio (with Edge splash screen) Right Section I load the picture with 212x64 (8 bit) 5KB click the arrow to copy the image from right to left Then Click save on the left section image

Here is the same thing if using OTX image

Also when picking the image when writing the flash to the radio it also does not work. image it still uses the edge tx logo

Version

2.9.2

Transmitter

FrSky X9D+2019

Operating System (OS)

Windows

OS Version

Windows 10 x64

Anything else?

No response

pfeerick commented 10 months ago

This is most likely an issue that can only be resolved in the short term by reducing the size/complexity of your splash screen so that it does fit. The reserved space for splash screens is slightly smaller (X9D family radios were running out of flash memory space, so it was either RLE compression or no custom splash screen at all). If selecting a too-large image when flashing the firmware fails silently and uses the stock image, rather than halting with the same error, that is a bug in Companion though IMO.

On Wed, Nov 22, 2023 at 7:58 PM Craig @.***> wrote:

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Companion Current Behavior

When using companion 2.9.2 (not work on others either) I get and error "Compress image size exceeds reserved space" when trying to save the firmware when copying the image over and then saving the firmware. [image: image] https://user-images.githubusercontent.com/40343747/284861342-e39f2f7a-a2c9-45d8-9ae2-e6d6aa6df737.png Expected Behavior

With the same image in other systems this works. Steps To Reproduce

If I use the Settings--> Edit radio Splash Screen Left section I load the firmware from radio (with Edge splash screen) Right Section I load the picture with 212x64 (8 bit) 5KB click the arrow to copy the image from right to left Then Click save on the left section [image: image] https://user-images.githubusercontent.com/40343747/284862697-85a81e85-2414-4f35-9a87-2f6f911c691a.png

Here is the same thing if using OTX [image: image] https://user-images.githubusercontent.com/40343747/284862833-1b5a34c5-f89f-4a83-8d39-3529dc461664.png

Also when picking the image when writing the flash to the radio it also does not work. [image: image] https://user-images.githubusercontent.com/40343747/284863260-0e06dbf9-6b5d-452d-997d-5bb6ad87966c.png it still uses the edge tx logo Version

2.9.2 Transmitter

FrSky X9D+2019 Operating System (OS)

Windows OS Version

Windows 10 x64 Anything else?

No response

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/4352, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ66KPNI4ZU7EMVHDW6TILYFXECPAVCNFSM6AAAAAA7V6F7E2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYDKOJXGI2DQNY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

craigywsm commented 10 months ago

@pfeerick Thanks for your input. Yes it does look like if I reduce it down to 1BIT PNG then it doe save. Here is the image for reference: 1bit It would be interesting to know the file size of the stock edge TX splash logo. Edge are no longer saving the models to the flash memory, they are now in yaml in the sd card should this not provide more storage? interested to know your thoughts

gagarinlg commented 10 months ago

Multiple answers: For the image size, there is no real answer. The images are bein compressed and the resulting size depends on the image contents

The models have never been stored in the same memory as the firmware. The models were stored in an EEPROM that is an extra IC in the radio and thee firmware is stored in the flash memory in the processor

craigywsm commented 10 months ago

thanks @gagarinlg for that information. I see what you mean there is no real answer for this one other than reducing the size of the image

craigywsm commented 10 months ago

After some testing I can get an image to work but it needs to be under 1KB Is there anything that can be done to allow more space for the image?

gagarinlg commented 10 months ago

Only be reducing the features for B&W radios