search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.49k stars 315 forks source link

Horus X12S Switch Bug #4483

Open ammikey opened 6 months ago

ammikey commented 6 months ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

Switch ID is lost in the programing screens ie: timer activation switch choice shows only arrows without the switch designation such as SH, or SG. Went back to 2.8 and it works as expected.

Expected Behavior

You should be able to see switch designations in drop down boxes.

Steps To Reproduce

Try to set switch actions no designations found just arrows.

Version

2.9.2

Transmitter

FrSky X12

Operating System (OS)

Windows

OS Version

No response

Anything else?

No response

pfeerick commented 6 months ago

I'm not seeing this on the Companion simulator with a new setup, so perhaps check what Radio Settings -> Hardware -> Switches shows for SG/SH ... what is the name of the switch set to there? It should be showing ---. There was a quirk in the conversions at one point where it was actually set to --- rather than being an empty value... so perhaps also clear the field by backspacing in it just to be sure.

Another way to check if you are more adventurous is to look at the RADIO/radio.yml file on your radio's SD card, look for the switchConfig block, and see what the names of each of your switches are.

i.e. A "blank" / default name switch:

   SA:
      type: 3pos
      name: ""

A switch with three spaces for the name, so it will show as a unnamed/blank switch:

   SA:
      type: 3pos
      name: "   "

If your switches show three spaces for the name, you could remove them so it just has "", but make sure you also change the manuallyEdited parameter at the top of the file from 0 to 1 so that the radio knows the changes to the file are intentional (as the checksum is no longer valid).

ammikey commented 5 months ago

Hi Peter. I just flashed the transmitter again with 2.9 and I still get the same problems the switch Id's are not in the drop downs and the input calibrations are way off. I reflashed 2.8 and everything works fine. I tried my transmitter setup in the 2.9 simulator and it works good there but not in the transmitter.

TramALot commented 5 months ago

I have gotten some of weird issues now and then. With input names not wanting to change after I had changed them once before. And it usually comes down to I left a global function or a special function set up some place and for some reason that causes it to hold/hide the name(s). But if you delete everything and start fresh it seems to go away(making a new model still fails). That's just my observation to something like what you're describing. And with a new radio like my T20 from jumper. The channel map sometimes needs to be manually adjusted on the inputs after switching in ms.

On Wed, Jan 17, 2024, 3:11 PM Fire Hunter @.***> wrote:

Hi Peter. I just flashed the transmitter again with 2.9 and I still get the same problems the switch Id's are not in the drop downs and the input calibrations are way off. I reflashed 2.8 and everything works fine. I tried my transmitter setup in the 2.9 simulator and it works good there but not in the transmitter.

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/4483#issuecomment-1896613981, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASL2VCQS3POSJNBBZPF2ODYPAWALAVCNFSM6AAAAABBHFJAA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJWGYYTGOJYGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Hartinger commented 5 months ago

I'm not seeing this on the Companion simulator with a new setup, so perhaps check what Radio Settings -> Hardware -> Switches shows for SG/SH ... what is the name of the switch set to there? It should be showing ---. There was a quirk in the conversions at one point where it was actually set to --- rather than being an empty value... so perhaps also clear the field by backspacing in it just to be sure.

I had the same problem with my Boxer and found indeed that the names of all controls consisted of three blanks. Removing these blanks cured the problem.

pfeerick commented 5 months ago

I have gotten some of weird issues now and then. With input names not wanting to change after I had changed them once before. And it usually comes down to I left a global function or a special function set up some place and for some reason that causes it to hold/hide the name(s). But if you delete everything and start fresh it seems to go away(making a new model still fails). That's just my observation to something like what you're describing.

This may be a different bug, which was fixed in 2.9.3

The channel map sometimes needs to be manually adjusted on the inputs after switching in ms.

If you mean the Def chan order (Default Channel Order)... that really only applies to creating new models, or if you delete all the inputs and re-add them. It won't change the order of existing inputs for models.

pfeerick commented 4 months ago

@ammikey I need you to check the RADIO/radio.yml file as per https://github.com/EdgeTX/edgetx/issues/4483#issuecomment-1873049090 or upload it here (either zip your MODEL/RADIO folder up and upload it, or change the extension of the file to txt to upload it to github) order to progress with this any further.

ammikey commented 4 months ago

I'll do it in a couple days

On Mon, Mar 4, 2024, 4:10 PM Peter Feerick @.***> wrote:

@ammikey https://github.com/ammikey I need you to check the RADIO/radio.yml file as per #4483 (comment) https://github.com/EdgeTX/edgetx/issues/4483#issuecomment-1873049090 or upload it here (either zip your MODEL/RADIO folder up and upload it, or change the extension of the file to txt to upload it to github) order to progress with this any further.

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/4483#issuecomment-1977628844, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXP7FDRGT7ZPM4E4VDOSE23YWT5PZAVCNFSM6AAAAABBHFJAA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZXGYZDQOBUGQ . You are receiving this because you were mentioned.Message ID: @.***>

pfeerick commented 3 months ago

few days plus reminder ;)

ammikey commented 3 months ago

Hi Peter, I'll send you the yml file tomorrow. Sorry it's taken so long. Thanks Mike J