search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.49k stars 314 forks source link

Trims switches still make sounds when disabled in DM #4527

Open txbone66 opened 5 months ago

txbone66 commented 5 months ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

Not sure if this is intended bahavior, but this is on the MT12. I have T1-T4 being used in Special Functions to adjust global variables and T5 as a sticky in logical switches. All 5 trims made the trim beeps, center, max and min (expected). When I turned off all 5 trims in DM0, T1-T4 still make the sounds while T5 does not.

Expected Behavior

I would think that T1-T4 should not make the trim sounds once it's turned off in DM0, T5 is the behavior I'm expecting.

Steps To Reproduce

Outlined above

Version

Other (Please specify below)

Transmitter

RadioMaster MT12

Operating System (OS)

No response

OS Version

No response

Anything else?

FW: edgetx-mt12 VERS: RM Factory

pfeerick commented 5 months ago

Unable to reproduce this with a recent nightly firmware, so this is most likely already fixed.

Please note you need to set all five trims to -- for them all to be disabled (as trims).

You can find the nightly for the mt12 here => https://buddy.edgetx.org/#/flash?version=nightly&target=mt12

philmoz commented 5 months ago

I think the issue is when a trim is both disabled and used to adjust a GV in a special function.

There is code that overrides the normal trim handling and instead adjusts the GV value. This is what plays the sounds and uses the GV value instead of the normal trim value to determine which sound. It does not look at whether the trim switch is disabled.

txbone66 commented 5 months ago

I was attempting to figure out how to get the sound to stop. I disabled all the trims in DM0, and noticed that T1 - T4 were still making sounds, and as @philmoz pointed out, even disabled, they are still make sounds with the common thread that they are all in the special function section. T5 was the interesting one because I'm using a sticky logical switch and then using special functions to overwrite a Channel value based on the !Lx or Lx, and for that one it doesn't make the sound. T5 is just an on / off for a halogen light bar.

What I'd really like is some control around the sounds, something like this:
Trim Sounds T1: All / Beeps Only / Center Only / Off

I'm about to head out of town, but when I get back, I'll take a backup and try that nightly to see if I can get it to replicate.

pfeerick commented 5 months ago

TR/ST trim still not beeping for me with all five trims disabled and a SF adjusting GV up and down... :shrug: I should point out this is when using the Trims as the triggers for the GV adjust. If you are using GV -> Adjust -> Mixer Source -> Pick-A-Trim, then yes, that looks like it makes it beep again.

What I'd really like is some control around the sounds, something like this: Trim Sounds T1: All / Beeps Only / Center Only / Off

It's best to ask that in a new feature request issue, as that's unrelated to this being a bug report, so will be lost if there is a bug and it's fixed ;)