EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.61k stars 340 forks source link

Preflight Checks: - Setting any switch to type "None" or "Toggle" breaks Preflight Check buttons to the right. #4652

Open qsiguy opened 9 months ago

qsiguy commented 9 months ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

If any hardware switch from SA - SG is set to type "Toggle" or "None" (my SF switch has been changed to a momentary), the default position buttons in model "Preflight Checks" to the right of the "Toggle" or "None" are broken. The switch button just to the right changes to "0" and all others to the right show their switch name but are stuck on the previously set position graphic. They do change color when active and do seem to function as expected, it appears to be cosmetic only. Pressing the "0" button causes some buttons to the right to also change state if they were previously pressed and if you sequentially press the buttons to the right and left others will randomly change.

I am on 2.9.4, I also tried 2.9.3, 2.9.2 and problem remained. Switching to 2.8.5 the issue was resolved. Switching back to 2.9.3 the issue returned.

I did not see any issue in Companion though did not thoroughly test.

If I set my toggle as a "2POS" the problem does not occur.

Expected Behavior

Changing a switch to type "Toggle" should drop it from the Preflight Checks button list only and not effect the remaining buttons.

Steps To Reproduce

Press SYS -> Hardware-> Switches. Change SA (or any switch with other active non-toggle switches after it) to "Toggle" or "None". Return to Model -> Model Setup -> Preflight Checks. SB (or the button after the one you changed) button will now show "0" and all others to the right will be stuck on the previous setting. Pressing may or may not change graphic and pressing the "0" after pressing buttons to the right will then cause other button graphics to change.

Version

2.9.3

Transmitter

RadioMaster TX16S / TX16SMK2

Operating System (OS)

Windows

OS Version

11

Anything else?

Switch preflight checks bug

philmoz commented 8 months ago

This is fixed in 2.10.