search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.54k stars 328 forks source link

Trainer settings per model and not system wide #4916

Open Papa-Echo opened 4 months ago

Papa-Echo commented 4 months ago

Is there an existing issue for this feature request?

Is your feature request related to a problem?

I am the instructor in our club and I have several students for quadcopter (FPV) flying and for FPV planes. The problem is that OpenTx and Edge-TX only have one setting for Instructor/Student in the SYS menues.

Describe the solution you'd like

I want to ask for a model specific Instructor/Student page. The reason is that I teach several students on the same day. One student is a beginner and I limit his % to 50. Then I have a more advanced student who can fly with 100%. The next student comes with his own plane or quadcopter and has a different order of channels. Or the calibration needs to be changed. Every time I need to change this SYS page. It would be much better if I could set up a model for each student and set specific values for the Instructor/Student mode.

Describe alternatives you've considered

This model trainer page could be added to the first model page if Instructor is selected.

Additional context

No response

pfeerick commented 4 months ago

Sounds like another candidate for the global/model level settings paradigm being introduced.

sande005 commented 3 months ago

I noted in a past that having a few system trainer configs, that could be assigned to any model would be beneficial - ie "Bobs Radio, "Sue's Radio" that then could be selected (perhaps even by a switch) for a particular model. OP carries this a step further and makes it all model specific. So a complete model for Sue and another for Bob. Can be limiting if the Instructor has several different models he will be using as a Master with the same students. (I solved the rate problem by putting "low" on a dial, and then I can adjust the actual weight in the air to what suits that student). The second example begs whether the students own plane/radio will be the master, or if the Instructor will setup and bind a new model so he can be the master. If the first case, then the setup for the slave TX has to be done in the student radio - which this proposal doesn't solve. OR beyond the work of duplicating/binding a new model in the Instructor radio, then either the OP's proposal or my variant will assist. Mine, of course, seems to follow the design parameters of keeping Sources distinct from use of those sources. Kind of like when Inputs was separated from the Mixer way, way back in the early days.

raphaelcoeffic commented 3 months ago

@sande005 the profile idea would be nice, indeed. In general, the trainer config is a bit weird right now. Parts of the settings are radio settings, some others are under model settings, and there are 5 different places to configure simple things. I'd really prefer some one-stop shop, rather than this complex setup.

sande005 commented 3 months ago

@raphaelcoeffic - I agree with you, a one-stop config is generally preferable. All of you are doing amazing work. It will be interesting to see what solutions you can come up with for this classic one-to-many and many-to-one problem! Whatever you do, rip up and throw away the current code in Companion for Trainers - it is very messed up (but was long,long ago in OpenTX also)