search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.45k stars 310 forks source link

add trim to subtrim no longer zeros trims #5028

Closed driedeker closed 1 day ago

driedeker commented 2 weeks ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

I mabe wrong but I thought add trim to subtim used to zero/centre the trims but not seeing it on my X9D+2019

Expected Behavior

trims to recentre after adding to subtim

Steps To Reproduce

use the option to add trim to subtrim

Version

2.10.0

Transmitter

FrSky X9D+2019

Operating System (OS)

Windows

OS Version

windows 11

Anything else?

No response

HippoDan commented 3 days ago

Still works correctly on 2.10 TX16s Mk2. This may be radio model specific.

pfeerick commented 3 days ago

I can't reproduce this on X9D+2019... pressing and holding on Trims => Subtrims (i.e. press and hold until you get the beep/haptic) to transfer the trims correctly adds the trims to the subtrims, and resets the trims to neutral. Have you been able to reproduce this again? @driedeker

driedeker commented 1 day ago

still not working for me. perhaps I am not doing it right what are you doing to copy the trims to subtrims .which way do you do it. I am going to outputs holding enter up pops the option to copy to subtrim hit enter go back to main munu and trims have not changed. now on 2.10.1

driedeker commented 1 day ago

Ok now I have found the copy to trim heading in outputs and that worked. what I was doing was as soon as I got to outputs hold enter up poped a menu with copy trim to subtrim enter on that and that did not work.

pfeerick commented 1 day ago

Ah, ok, that option is different. It only copies/adds (duh!) the trim to subtrim, not moves, hence is working as intended.

On Fri, 31 May 2024, 10:27 pm Driedeker, @.***> wrote:

Ok now I have found the copy to trim heading in outputs and that worked. what I was doing was as soon as I got to outputs hold enter up poped a menu with copy trim to subtrim enter on that and that did not work.

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/5028#issuecomment-2141977678, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ66KIP7MDQNDAFFYRGLP3ZFBUBZAVCNFSM6AAAAABH4QW6LOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRHE3TONRXHA . You are receiving this because you commented.Message ID: @.***>