EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.55k stars 331 forks source link

Companion Simulator shows wrong tx battery voltage #5053

Open MirlynG opened 3 months ago

MirlynG commented 3 months ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Companion

Current Behavior

When opening a model on RM Pocket in Simulator, it shows the wrong battery voltage on the model page. i.e, radio voltage is 8.0 but shows a 6.7 in sim. It also plays the low battery warning, even though the battery range is set to 6.6-8.4v.

Expected Behavior

I'd expect that the simulator will reflect the radio voltage correctly.

Steps To Reproduce

Open a model in simulator and see resulting error.

Version

2.10.0

Transmitter

RadioMaster Pocket

Operating System (OS)

Windows

OS Version

10

Anything else?

I have uploade a video here: https://drive.google.com/file/d/1DZsGEfZc3gTu2-D8ZLq2N17LX7roOa2u/view?usp=sharing

CompSim1 CompSim2 Radio1 Radio2

3djc commented 3 months ago

How exactly do you expect the simulator to know your radio battery voltage?

what you are showing is not the alarm range, but the indicator range. Alarm is a bit below

MirlynG commented 3 months ago

This was all done immediately after reading from the tx and saving the .etx file. I would expect the voltage on Companion to be the same as it was at that time. I realise it won't change.

As for the alarm, yep my mistake.

3djc commented 3 months ago

Clearly not how it is designed to work, so not a bug. what you want is an enhancement then, but I'm not overly sure it makes a lot of sense. Maybe allow to change it on the telemetry simulation panel

pfeerick commented 3 months ago

This is the same for all radios btw, not specific to the RM Pocket or Windows. It is a hard-coded value that with stock settings shouldn't trigger the battery alarm. Not sure if it belongs in the telem simulation panel though, as it is a handset value, not telemetry... although there isn't really anywhere else to put it... i.e. it could be a simulator preference, but then that makes it hard to change if you want to change it dynamically... what about a dialog box off the tools menu?

Chris-1066 commented 3 months ago

I have a similar issue with the Companion 2.10 simulator (Mac OS) and a RM Boxer. On Companion 2.9 simulator the Boxer battery is set to 7.9V and doesn't trigger my LV alarm (7.2V for 2S lipo):

screenshot_boxer_24-05-25_09-14-50

However, on Companion 2.10 simulator the Boxer battery is set to 6.5V and, hence, does trigger my LV alarm, which is annoying whilst trying to check out settings using the simulator:

screenshot_boxer_24-05-25_09-16-58

To get around this I'm reducing the LV alarm setting to 6.4V in the radio settings and then trying to remember not to write these settings to the radio (I think 3.2V/cell is too low for a lipo).

As I understand it, the 7.9V/6.5V values are hard coded in to the simulator and cannot be changed by the user? Is there any other way to disable the LV alarm in the simulator without altering the radio LV settings that are sent to the radio?

beau76 commented 1 month ago

I am seeing the same problem with a boxer with all the default settings and the battery alarm goes off in the simulator