search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.63k stars 345 forks source link

TX16S, EdgeTX 2.10.0, no S.Port telemetry from external module? #5064

Open keithluneau opened 6 months ago

keithluneau commented 6 months ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

No sensors discovered on the model settings telemetry tab when using S.Port telemetry in the external module bay after upating to 2.10.0

It was working in 2.9.2, and also works after rolling back to 2.9.4

For context, I'm using a Dragonlink module connected to the external module bay using SBUS protocol, which feeds S.Port telemetry back to the S.Port pin in the module bay at 57600 baud.

Expected Behavior

Sensors should be discovered like in previous firmware.

Steps To Reproduce

Feed telemetry into the external module bay's S.Port pin. Go to model settings, telemetry tab, delete any previously discovered sensors if present, try to discover new sensors and none are found.

Version

2.10.0

Transmitter

RadioMaster TX16S / TX16SMK2

Operating System (OS)

No response

OS Version

No response

Anything else?

No response

klaashartmann commented 5 months ago

I had this same issue. Rolling back to 2.9.0 or 2.9.4 did not work. But the discussion here: https://github.com/EdgeTX/edgetx/issues/3877 had me suspicious that the problematic change was introduced in 2.9.0.

After rolling back to 2.8.0 it has worked seamlessly for me. I am not sure how it was working for the original poster in 2.9.0.

pierrotm777 commented 5 months ago

Same issue with a DIY MPM external module. NO telemetry found on my TX16 and EdgeTx 2.10.0. RC3

Blooskyy commented 5 months ago

I have experienced a similar issue where certain telemetry sensors (eg altitude) aren't discoverable after updating to 2.10. However after restoring back to 2.9.4 they work perfectly. Not sure if this is an EdgeTX issue but without this working it won't be possible to upgrade. TX16S

Amigache commented 3 months ago

I have the same problem, after updating to 2.10.0, I cannot obtain telemetry information through the s.port of the external module, I am using Mav2PT and DL

keithluneau commented 3 months ago

I have the same problem, after updating to 2.10.0, I cannot obtain telemetry information through the s.port of the external module, I am using Mav2PT and DL

Unfortunately this still seems to be a problem, and with no response from anyone at EdgeTX I've resorted to rolling firmware back to 2.9.4 and sticking with that until it gets addressed.

nspector8 commented 3 months ago

I tried seeing if 2.10.3 may have corrected this issue, but still no telemetry in Yaapu.

This is with TX16S and RFD TXMOD in external bay.

Continuing on with 2.9.4.

packetkiller commented 2 months ago

I can also confirm that with RFD 900x v2 and TXMOD v2 radios both SBUS Telemetry and RC link are affected (not working) with EdgeTX 2.10.2. Works on EdgeTX 2.9.4. Verified with 4 different sets of these radios. Seems to be an EdgeTX thing. I do get telemetry using TBS Crossfire radios using EdgeTX 2.10.2.

nspector8 commented 2 months ago

Attempted 2.10.4 with all fresh SD content and yaapu script, but still no fix.

RC link with SBUS and telemetry passthrough to MP is perfect, but zero telemetry in the radio.

TX16S Mk II Matek H743-WLITE RFD TXMOD v2.0 RFD 900ux v.2.0

Blooskyy commented 2 months ago

I had solved the telemetry issue by increasing the baud rate from 115k to 400k on the TX16S. Worth giving it a try.

https://www.expresslrs.org/quick-start/transmitters/tx-prep/#serial-baud-rate

On Wed, Sep 25, 2024, 01:17 nspector8 @.***> wrote:

Attempted 2.10.4 with all fresh SD content and yaapu script, but still no fix.

RC link with SBUS and telemetry passthrough to MP is perfect, but zero telemetry in the radio.

TX16S Mk II Matek H743-WLITE RFD TXMOD v2.0 RFD 900ux v.2.0

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/5064#issuecomment-2371872555, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF4S4NP4XPYXUVZ6WGQK6RDZYGNA7AVCNFSM6AAAAABIHUKHOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZRHA3TENJVGU . You are receiving this because you commented.Message ID: @.***>

nspector8 commented 1 month ago

Thanks for the suggestion Blooskyy! Unfortunately though, adjusting my RFD900ux/TXMOD settings to 230400 and 460800, as well as the associated serial baud rate in the FC to the same, had no effect. Also, since I'm using SBUS for RC link, there is only refresh rate available as a value to adjust in EdgeTX (default 7.0ms), and no adjustment for baud rate, unless there is a way to correlate that.

pierrotm777 commented 1 month ago

Try 400k and not 460,8k.

cardboardboks commented 1 month ago

Attempted 2.10.4 with all fresh SD content and yaapu script, but still no fix.

RC link with SBUS and telemetry passthrough to MP is perfect, but zero telemetry in the radio.

TX16S Mk II Matek H743-WLITE RFD TXMOD v2.0 RFD 900ux v.2.0

Same setup here with the same issue - TX16S Mk II Cube orange on carrier board RFD TXMOD v2.0 RFD900x RC link with SBUS and telemetry passthrough to MP is perfect, but zero telemetry in the radio. Rolled back to 2.9.4 as well and it works.

nspector8 commented 1 month ago

Try 400k and not 460,8k.

I believe I tried 400k first, but sadly no effect.

cardboardboks commented 1 month ago

default was 400k I believe and I tried 115k as well, both no joy

robertlong13 commented 1 week ago

There seems to be some muddying the waters in this thread. @keithluneau 's issue is specifically that 2.10 cannot receive S.Port telemetry on the S.Port pin when using an external module using takes SBus for the channels.

This is the same issue reported in #3877, and fixed for 2.9.4 with #3986, but that fix did not go into main/2.10. In the discussion of #3986, @raphaelcoeffic mentioned that #3780 was a better fix in the long run, but notably, SBus is not touched in #3780.

I think (but did not think to test before I rolled back), that PPM with S.Port telemetry on the S.Port pin does work in 2.10, but those of us trying to use SBus with S.Port telemetry on RFD TXMods are out of luck.

@raphaelcoeffic, do I have this analysis correct?

nspector8 commented 1 week ago

@robertlong13,

To my knowledge, @keithluneau is not using RFD hardware, but rather an ELRS external module.

i.e., this issue is not isolated to RFD users.

robertlong13 commented 1 week ago

@nspector8

To my knowledge, @keithluneau is not using RFD hardware, but rather an ELRS external module.

Nope, he says right in the OP that he's using DragonLink with SBus+S.Port, which as far as EdgeTX is concerned is the same as those of us running an RFD TXMod with SBus (like a few other people in this thread).

This is exactly what I meant by the waters being muddied. There might also be some other issue with external ELRS modules, I don't know, but I don't think it's related to this issue.

keithluneau commented 1 week ago

I'm actually seeing the problem when using a Dragonlink module. ELRS communicates with the handset via CRSF and isn't related.

When using Dragonlink, the handset sends data out to the module via sbus. The module has the ability to send telemetry to the handset using S.Port.