backup file path ignored in 2.10.1

19Roger53 commented 4 months ago

Is there an existing issue for this problem?

[X] I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Companion

Current Behavior

I just installed 2.10.1 and entered a file path for back ups but my chosen path is ignored and replaced by the wrong folder

Expected Behavior

I expect the file path to be recognized

Steps To Reproduce

I have been using Edge tx companion 2.8.1 since its inception

installed Edgetx companion 2.10.1
1. in settings I selected a file path for my models backup folder
went to file dialog box, chose 'open' and hit enter
it then opened to the wrong folder

I re-entered the folder that i wanted multiple times but it kept going to the wrong folder

i also deleted 2.10 and re-installed but still have the same problem

Thank you for your help

Version

2.10.1

Transmitter

RadioMaster TX16S / TX16SMK2

Operating System (OS)

No response

OS Version

windows 10

Anything else?

setting 493 file dialog 494 open file 495 opens to wrong file 496

19Roger53 commented 4 months ago

correction: the OS on that PC is Windows 8.1

elecpower commented 4 months ago

That is the folder location for each radio backups. It is used by the Read/Write menu items Backup Radio to File and Write Backup to Radio both of which are currently disabled. Also used when the checkbox below the folder location is checked for the purpose stated. Companion should save and open the last used settings folder but there is an issue #4813 identifying that this is not working.

pfeerick commented 4 months ago

I think there are two separate issues here...

The first time you run through the steps given

1. installed Edgetx companion 2.10.1
2. in settings I selected a file path for my models backup folder
3. went to file dialog box, chose 'open' and hit enter
4. it then opened to the wrong folder

I wouldn't really expect it to open the path set in step 2 in step 3. File -> Open for is not specifically for opening the backup folder. Don't confuse Backup folder with (a nonexistent) Default Open/Save Folder option. Instead I would have been expecting probably the Documents folder to open, and then maybe the last opened folder after that... that it doesn't remember the last opened folder I do consider to be a bug, or at least a behaviour that could be improved on.

It would be nice to have option to set the default open folder, both at Radio Profile and Application Settings level... i.e. another field at the radio profile level that if blank reverts to Application Settings level setting, otherwise always uses to the configured path for open/save dialogs. At the application settings tab level, it would have similar to the "automatic backup folder" layout... a field that is blank by default, which is used as the global open/save path if set, and the checkbox would be to disable the field, and instead use last opened folder.

19Roger53 commented 4 months ago

An extra bit of information to hopefully clarify my understanding: In the past, using ETx 2.8 and several years of OpenTx my steps to get into my saved files were as I outlined: In Open or EdgeTx, hit File, then Open, which opened to the named Backup folder (from the settings page) with my saved model and radio settings files. After discovering that doesn't happen in 2.10.1 i'm thinking i have been blessed all these years for it to have been working that way.

3djc commented 4 months ago

Clearly I would not like to have it operate this way. Remember last used directory yes, open backup, nop please

EdgeTX / edgetx