EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.59k stars 338 forks source link

R9 Receiver Flashing OTA FRSK files - FRSK not recognized as a valid firmware. #538

Open MartyFufkin opened 3 years ago

MartyFufkin commented 3 years ago

I tried to flash an R9 Mini OTA receiver with an OTA firmware which ends in file extension ".FRSK". This file extension is not recognized by the Edge firmware on my TX16S as a flashable external file and does not work. I flashed FRSK file type successfully with OpenTx on another Taranis radio I have.

Firmware available for testing at: https://www.frsky-rc.com/r9-mini-ota/

raphaelcoeffic commented 3 years ago

I tried to flash an R9 Mini OTA receiver with an OTA firmware which ends in file extension ".FRSK". This file extension is not recognized by the Edge firmware on my TX16S as a flashable external file and does not work. I flashed FRSK file type successfully with OpenTx on another Taranis radio I have.

Firmware available for testing at: https://www.frsky-rc.com/r9-mini-ota/

Small issue here: I don‘t own any OTA receivers. So it might become quite fun to fix this properly.

MartyFufkin commented 3 years ago

I used to do some development 20 years ago... I may look at it and get my feet wet again. I certainly have a work around (Taranis). If you need a guinea pig to test for you, happy to do that for you as well.

raphaelcoeffic commented 3 years ago

I used to do some development 20 years ago... I may look at it and get my feet wet again. I certainly have a work around (Taranis). If you need a guinea pig to test for you, happy to do that for you as well.

If you manage to fix it, that would be of course the best/fastest option! Another would be to use a logic analyser to trace the communication on S.Port while OTA flashing with your taranis. This way, we could even find a way to simulate that module.

edit: wait, this is R9 Access, right? Then you need to trace both TX/RX used by the external module.

MartyFufkin commented 3 years ago

Yes, it is R9 Access. I think it is simpler than that (although I may be wrong)... Flashing an FRK files works... FRSK files are just not identified by the Edge firmware as being a valid firmware file so the only options are Copy and Delete. Flash External and Flash Internal do not come up as options.

raphaelcoeffic commented 3 years ago

Yes, it is R9 Access. I think it is simpler than that (although I may be wrong)... Flashing an FRK files works... FRSK files are just not identified by the Edge firmware as being a valid firmware file so the only options are Copy and Delete. Flash External and Flash Internal do not come up as options.

I see, this is indeed easy to fix :-)

brainbubblersbest commented 3 years ago

Small issue here: I don‘t own any OTA receivers. So it might become quite fun to fix this properly.

You dont have a Single r-xsr with accst anywhere? It Supports OTA after updating to access. Time to play with the isrm in your RM. 😉

I remember of a commit on otx that whas in need to Support OTA with frsk files.

pfeerick commented 3 years ago

A better comparison would have been OTX and ETX on the TX16S, as the TX16S may not be able to do everything update related comparied to the Taranis or X7, etc.

On OTX with the TX16S, both .frk and .frsk extensions add the Flash external module option to the popup menu.

On ETX, with the TX16S, .frk adds the 'Flash internal module' (hm... really?!) and 'Flash external module', and .frsk doesn't add anything.

I suspect that the internal flash entry is because https://github.com/EdgeTX/edgetx/blob/3eeca550dad17b174848f9bea59a0e5b8d45b9d5/radio/src/gui/colorlcd/radio_sdmanager.cpp#L329-L350 doesn't have include guards like https://github.com/opentx/opentx/blob/d67d1aa0c09d2f485c3ef7ca8c4fb1e9214a2ee7/radio/src/gui/480x272/radio_sdmanager.cpp#L375-L382

And the FRSKY_FIRMWARE_EXT handling looks to be entirely missing... i.e. similar to this... https://github.com/opentx/opentx/blob/d67d1aa0c09d2f485c3ef7ca8c4fb1e9214a2ee7/radio/src/gui/480x272/radio_sdmanager.cpp#L383-L399

pfeerick commented 3 years ago

If you're brave, and willing to give it a try, #543 appears to add the entry, and may or may not actually flash the receiver firmware. I have nothing to test it with, so it has only gotten the "simu shows an entry for frsk file and says it wants to run the update process test." simulation test.

MartyFufkin commented 3 years ago

I will give it a shot... (although I just ordered a full set of everything Crossfire)... nothing to lose bricking anything.

raphaelcoeffic commented 3 years ago

I will give it a shot... (although I just ordered a full set of everything Crossfire)... nothing to lose bricking anything.

Worst case, send me the bricked hardware, I will make good use of it ;-)