search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.64k stars 346 forks source link

Radio settings and calibration should be separated #5470

Closed pfeerick closed 3 months ago

pfeerick commented 3 months ago

I think it would be a good idea to split the calibration and hardware settings into a separate file, thus effectively making the RADIO/radio.yml less radio hardware specific, and more transferable between handsets. This would also effectively be the "factory hardware settings" that you would want to be able to backup to EEPROM/SPI flash. ;)

elecpower commented 3 months ago

Refer #381

pagrey commented 3 months ago

Does the voltage calibration belong in settings? Does the number and type of switches belong in settings? If you can't answer in a concrete way which thing is a setting and which is a calibration then maybe splitting them doesn't make sense.

The radio.yml file will always depend on the hardware configuration so why split it up? Seems like the UI in companion for managing the calibration settings is the main issue.

pfeerick commented 3 months ago

Thanks Neil, was bugging me as I was sure I had created or seen an issue for this before.

On Wed, 21 Aug 2024, 9:54 pm Neil Horne, @.***> wrote:

Refer #381 https://github.com/EdgeTX/edgetx/issues/381

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/5470#issuecomment-2301868520, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ66KOQGRIQHRL2ALSGLVDZSR5YXAVCNFSM6AAAAABM3UNC6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBRHA3DQNJSGA . You are receiving this because you authored the thread.Message ID: @.***>

pfeerick commented 3 months ago

Does the voltage calibration belong in settings? Does the number and type of switches belong in settings? If you can't answer in a concrete way which thing is a setting and which is a calibration then maybe splitting them doesn't make sense.

It depends on what you mean by "settings". Settings UI? There is nothing wrong with the current UI per say... all the hardware specific stuff is one place - funnily enough on a page called "HARDWARE" (hint, hint?). Settings file - it should be split, so that the radio settings is separate to the hardware settings. i.e. consider the situation where you have two TX16S - you currently can't just copy the radio.yml between them... you need to calibrate afterwards. Wouldn't be necessary if you had a separate calib.yml or hardware.yml file the RADIO folder. Or a EL18 and TX16S (which have completely different switch configurations)... again, not an issue if they are broken into a separate file.

The radio.yml file will always depend on the hardware configuration so why split it up? Seems like the UI in companion for managing the calibration settings is the main issue.

No, it won't... how does the screen brightness, audio levels, or configured general functions (ok, I know this is the murkey middle ground) specifically depend on hardware? Note, the murkey middle ground could be resolved with virutal/assignable controls, which is itself another request around here. (i.e. rather than configuring your arm switch as SF, you configure it as ARM, and you then assign that on a per radio basis).

Duplicate of #381

elecpower commented 3 months ago

Thanks Neil, was bugging me as I was sure I had created or seen an issue for this before.

Forgiven as it was 4000+ issues ago