search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.62k stars 340 forks source link

Bump EdgeTX internal precision #5528

Open 3djc opened 2 months ago

3djc commented 2 months ago

This is more for getting feedback on how we would handle bumping internal precision if we where to decide to do it.

Currently, values are expressed in %, µs or -1024 to +1024. If we where to mode to say 14 or 16 bits, % and µs would still work, but what would we need to do with the usual -1024 to +1024 ?

1) leave it as is for display, rounding up higher precision internal values to match this

2) use larger values, up to -32000 + 32000 for 16 bits for example

3) another idea ?

Side comment: EdgeTX internal precision does not affect what various RF protocol send over the air. Currently, most RF protocols support 11 bits maximum, and quite often less.

pfeerick commented 2 months ago

Well, they do say bigger is better, don't they? 🤭

Personally, for us mere mortals... I would prefer leaving the display as is... as I'm not sure having say -32000 - 0 - 32000 is going to be more ... meaningful ... although I do then also understand it is not a true and accurate representation of the data being manipulated... so 😖 ... maybe it does need to be whatever resolution it ends up... probably 12bit (Ghost has been 12bit OTA since v1.0.4.0 for primary controls, and fully 12bit since v1.0.5.4) until some new tech comes along...

3djc commented 2 months ago

Leaving it at current scale does have the great side benefit of leaving current model programming untouched.

It does have the drawback to not add precision at programing (LS, SF,..), but I don't think it is needed there anyway

richardclli commented 2 months ago

As I know the highest precision of the TX part is 13-bit. Flysky told me this is the highest designed resolution in AFHDS3, but not sure which mode has this precision.

Well, they do say bigger is better, don't they? 🤭

Personally, for us mere mortals... I would prefer leaving the display as is... as I'm not sure having say -32000 - 0 - 32000 is going to be more ... meaningful ... although I do then also understand it is not a true and accurate representation of the data being manipulated... so 😖 ... maybe it does need to be whatever resolution it ends up... probably 12bit (Ghost has been 12bit OTA since v1.0.4.0 for primary controls, and fully 12bit since v1.0.5.4) until some new tech comes along...

pagrey commented 2 months ago

If it's ever done, maybe internal at first and then a display option if people ask? If the precision is displayed maybe an option that allows %, µs, 1K or 32K so people can choose and the radio can convert display values? As far as usage, with a scroll wheel 32,000 could be allot of scrolling, maybe too much to be useful at all on some radios.