companion program crashes when edit intern HF module at Pocket radio

[meyer1111]

Is there an existing issue for this problem?

• [X] I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Companion

Current Behavior

Companion program crashes when edit intern HF module (4in1, not CC2500!) at Pocket radio.

Internal RF 4in1 works very well. (ELRS has been replaced by 4in1 module) But when i create a new model, the program crashes when edit intern HF module. When i create a new model in the transmitter, the transmitter does not crash. After this it can then be edited in Companion without any problems.

Expected Behavior

Protocol selection without crash (4in1 internal HF-Module).

Steps To Reproduce

1. create new model with companion
2. Protocol selection (internal HF module)

Version

2.10.4

Transmitter

RadioMaster Pocket

Operating System (OS)

Windows

OS Version

Win11 64bit, Win7 32bit

Anything else?

No response

[meyer1111]

Supplementary information: Companion program crashes when edit intern HF module, regardless if CRFS or 4in1 module default setting.

[pagrey]

It works for me. Be sure you change the radio profile settings to specify the internal module before you create the etx file. The module type is stored in the file. You can't open an existing etx file and change the internal module type. The setting only applies when the etx file is created.

[elecpower]

I cannot reproduce in Win 10 64 bit.

[elecpower]

It works for me. Be sure you change the radio profile settings to specify the internal module before you create the etx file. The module type is stored in the file. You can't open an existing etx file and change the internal module type. The setting only applies when the etx file is created.

To clarify, in Companion you can change the radio profile Default Int. Module and each Models and Settings file Hardware Internal RF type at any time.

The radio profile Default Int. Module is used to set the Hardware Internal RF type for New Models and Settings files. When you select New Model, the Hardware Internal RF determines which internal module types are available for the new model.

Changing the radio profile Default Int. Module will only apply to new Models and Settings files.

Changing the Hardware Internal RF of an existing Models and Setting file will trigger an update to the Internal RF of all models within that file. Should a model's Internal RF be incompatible with the new Hardware Internal RF then the model's Internal RF will be set to OFF.

[elecpower]

@meyer1111 I would suggest you delete and recreate the Pocket radio profile and retry. There maybe some unrelated values that are triggering the crash.

[pagrey]

Once the etx file is created the internal module type cannot be changed, I have tested several times. If I have the default internal module set to CSRF and create an etx file and add a model I have the option of crossfire for the internal module. If I change the internal model to MULTI in settings and add another model it turns the internal module to off but the only option available again is still Crossfire. Once the etx file is created Multi cannot be added to a new model.

Edit: I just double checked, internalModule: TYPE_CROSSFIRE remains in radio.yml regardless of changes to the internal module type

[elecpower]

@pagrey what version and radio profile are you using for your tests?

[pagrey]

I compiled a version of 2.10.4 with the Pocket simulator module to test this issue, I haven't tried with any other radio just because I wanted to get a clean build to test this particular issue. It's running on Linux.

[elecpower]

Thanks for the info. I'll recheck with this combo when I have some time.

[meyer1111]

I delete and recreate the Pocket radio profile and retry. With default setting: Multi. Now: everything is fine! :-)

Thank you very much! :-)

[meyer1111]

EdgeTX ist great!

[pagrey]

Great you got it all working.