search

EdgeVerve / feel

Expression Language for creating and executing business rules in decision table based on DMN 1.1 specification for conformance level 3
MIT License
93 stars 48 forks source link

Update dependencies. #17

Open bkaney opened 4 years ago

bkaney commented 4 years ago

Thanks for the work on this library!

This PR addresses some critical audit problems. Also the upgrade to XLSX allows it to work in React (my main motivation for doing this :)).

There are a few dev dependencies that fail audit, namely istanbul, which is a deprecated package. Perhaps in a future PR this can be replaced with nyc (https://www.npmjs.com/package/nyc)...

bkaney commented 4 years ago

This fails CI because .travis.yml specifics node 6, which doesn't have the spread operator for literals (would need at least node 8, see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax).

Since node 6 is not longer being maintained, would it be appropriate to keep the node version at least what is being maintained (https://nodejs.org/en/about/releases/) -- so allow node 8 until Jan 2020, then bump to node 10?