search

Edgio / hurl

http(s)+h2 server load tester
153 stars 34 forks source link

Add macro to find sanitizer libraries #31

Closed ghost closed 3 years ago

ghost commented 3 years ago

Add macro to find sanitizer libraries on Linux The integration with fail_if_not_found macro was listed as a TODO, it would be better to add a separate macro to find the sanitizer libraries since it's a good use case to match against multiple libraries as opposed to one (giving precedence to an unversioned one)

ghost commented 3 years ago

When the library is not found, debug is as follows,

CMake Error at CMakeLists.txt:61 (message):
  asan library not found

Call Stack (most recent call first):
  CMakeLists.txt:84 (fail_if_not_found_sanitizers)
CMake Error at CMakeLists.txt:61 (message):
  ubsan library not found

Call Stack (most recent call first):
  CMakeLists.txt:98 (fail_if_not_found_sanitizers)

Platform: CentOS

Could not test the negative case on Ubuntu as the compiler tool-chain installs sanitizer libraries by default

tinselcity commented 3 years ago

It seems fine as is -really appreciate the contribution! Thanks -I can work on adding CentOS to the GitHub CI Actions if possible.