Edgio / vflow

Enterprise Network Flow Collector (IPFIX, sFlow, Netflow)
http://www.verizonmedia.com
Apache License 2.0
1.08k stars 224 forks source link

Abandoned project? #172

Open dbardbar opened 1 year ago

dbardbar commented 1 year ago

Hi

I'm seeing many issues without any response and no comments/approvals from maintainers on pull requests. Is this project abandoned? Does anyone know the who official maintainers are? I've tried to reach @mehrdadrad, but to no avail. Any ideas how to proceed?

thehelix112 commented 1 year ago

Hey @dbardbar, sorry for the lack of updates here. vflow is still heavily utilized internally to Edgio, however we have largely been working on it in an internal fork that we need to bring back into alignment with the open source version here (and then keep them in sync in the future). Not abandoned.

mehrdadrad commented 1 year ago

I would like to help but I don't have any test environment for testing new changes.

thehelix112 commented 1 year ago

@akshah

petiepooo commented 1 year ago

@mehrdadrad The Docker section of this repository's readme references a dockerhub image under your name that is currently quite old. If you want to show the world that this project is still actively maintained, updating that might help.

I'd love to try vflow out, but would want to build my own image rather than use something over two years old...

akshah commented 1 year ago

Hi @petiepooo , I can take that. Looking for anything specific? We can discuss more.

This project is active, a few recent optimizations we've made to scale more coming soon as well.

petiepooo commented 1 year ago

Thank you, akshah. Looking forward to those scaling optimizations.

I had used elastiflow in the past, but don't like the direction it's taken lately, so am investigating alternatives.

I'm looking for a way to ingest ipfix/netflow and push it into elasticsearch for slicing and dicing. ECS is ideal, but we're adept at syslog-ng and json remapping so can do that separately. We're avoiding logstash/beats in hopes of improved throughput and reliability.

gaby commented 1 year ago

I just found this project, looking forward to a new release. I'm going to try to run the tests locally and see if I can get dependencies updated

gaby commented 1 year ago

@dbardbar @mehrdadrad @thehelix112 @petiepooo @akshah I just pushed PR #188 to hopefully get the ball rolling with this project. All my changes were based on running the following commands:

go test -v -timeout 1m ./...
go test -v -race -timeout 2m ./...

Running -race with 1m timeout causes the following:

==================
WARNING: DATA RACE
Write at 0x00c000032310 by goroutine 12:
  runtime.closechan()
      /snap/go/current/src/runtime/chan.go:357 +0x0
  github.com/EdgeCast/vflow/vflow.TestMirrorIPFIX.func2()
      /home/ubuntu/Desktop/git/other/vflow/vflow/ipfix_test.go:70 +0x214

Previous read at 0x00c000032310 by goroutine 10:
  runtime.chansend()
      /snap/go/current/src/runtime/chan.go:160 +0x0
  github.com/EdgeCast/vflow/vflow.TestMirrorIPFIX.func1()
      /home/ubuntu/Desktop/git/other/vflow/vflow/ipfix_test.go:49 +0x128

Goroutine 12 (running) created at:
  github.com/EdgeCast/vflow/vflow.TestMirrorIPFIX()
      /home/ubuntu/Desktop/git/other/vflow/vflow/ipfix_test.go:58 +0x324
  testing.tRunner()
      /snap/go/current/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      /snap/go/current/src/testing/testing.go:1629 +0x47

Goroutine 10 (finished) created at:
  github.com/EdgeCast/vflow/vflow.TestMirrorIPFIX()
      /home/ubuntu/Desktop/git/other/vflow/vflow/ipfix_test.go:44 +0x204
  testing.tRunner()
      /snap/go/current/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      /snap/go/current/src/testing/testing.go:1629 +0x47
==================
Found 1 data race(s)
dbardbar commented 1 year ago

@gaby,

The only one here that is allowed to approve PRs and is still somewhat active is @akshah. But my PRs have been waiting for about 4 months now, so this may take some time...

gaby commented 1 year ago

@dbardbar Thanks for the info! Should I keep adding other fixes in my PR or wait? The repo is already quite behind what a regulat Go repo looks like. I figured fixing the golangci-lint and gosec issues should be a separate PR since there's around 30-40 of those.

This is the only project I have found with sflow/netflow, clickhouse and grafana dashboard.

dbardbar commented 1 year ago

@gaby, I'm not a golang developer. I inherited the usage of this project in my place of work, so I just do minimal fixes as needed. So I can't say if what you're doing in your PR is good, or what's the best way to move forward.

Try to get @akshah or @thehelix112 attention for input. Best of luck!

gaby commented 1 year ago

@akshah Any news? :-)

akshah commented 1 year ago

@gaby thanks for following up. Still in the backlog of things to do, trying to play catch-up. I will try and get to at least a few PRs this month.

gaby commented 1 year ago

@akshah Thank you! 🙌

gaby commented 10 months ago

@akshah It's been almost 6 months and I havent heard back

gaby commented 6 months ago

I'm closing the PR