Other small suggestions

[lucydot]

Hello,

Continuing with the JOSE review (https://github.com/openjournals/jose-reviews/issues/192) - now working through the "Pedagogy / Instructional design" section. I'll add more here as they come up.

Note: I haven't ran these through binder (see https://github.com/Edinburgh-Chemistry-Teaching/Data-driven-chemistry/issues/39) so reading the notebooks straight up.

• LO's for section 10 are written in different style (longer sentence) than the other parts (its a small point I know!)
• there are a few "FIXMEs" in various places (e.g. unit 2 and unit 3). I don't think this is necessarily a Bad Thing as resources are in a continuous form of improvement, but easier to use as-is if they are removed.
• on a similar point to the previous, I was a little confused as to whether this is designed as a clone-and-go project, or whether you are expecting instructors to edit before they can use - as there are some parts which seemed to be talking to instructors rather than students - e.g. the Mentimetre section here. I expect most instructors would want to edit before teaching, but it might be nice to flag this up if it is required.

The Mentimetre functionality is great!

[ppxasjsm]

Noted! @jcumby, would you be up for adjusting these?

[ppxasjsm]

LO's for section 10 are written in different style (longer sentence) than the other parts (its a small point I know!)

Commit f441cac should fix this.

there are a few "FIXMEs" in various places (e.g. unit 2 and unit 3). I don't think this is necessarily a Bad Thing as resources are in a continuous form of improvement, but easier to use as-is if they are removed.

I'll double check, but all the FIXMEs should be tasks students would need to try and solve. The FXIME is just a dummy comment in an empty cell for them to add their code. If that is confusing I could swap this out to your solution here? Or just a blank cell? Thoughts?

[..] was a little confused as to whether this is designed as a clone-and-go project, [...]

Yeah good point. I'll make this a bit clearer. Will comment here when I've done that.

[ppxasjsm]

ee993ff adds and extensive overview file to the repo explaining how you can use it. This also includes an explanation for the FIXME tag, which basically means you as a student have to write an answer to a task in this cell. @lucydot , if you think FIXMe is not a good way for doing this, I am open to other suggestions.

But I believe I have now addressed everything in this issue.