Edinburgh-Genome-Foundry / DnaChisel

:pencil2: A versatile DNA sequence optimizer
https://edinburgh-genome-foundry.github.io/DnaChisel/
MIT License
213 stars 38 forks source link

Why self.sequence = self.sequence_before while doing optimize_by_exhaustive_search? #21

Closed Lix1993 closed 4 years ago

Lix1993 commented 4 years ago

https://github.com/Edinburgh-Genome-Foundry/DnaChisel/blob/78043a3bc04cb9c175013fde043555625b613774/dnachisel/DnaOptimizationProblem.py#L570

Zulko commented 4 years ago

You are right, this is an oversight. As I understand it, this line does nothing at all actually.

In case you are analyzing the code, just a warning note that I will soon push a v3.x on Github with very re-organized code (same code but different file organization) and some small API changes.

Zulko commented 4 years ago

removed in the last update