search

Edinburgh-Genome-Foundry / DnaChisel

:pencil2: A versatile DNA sequence optimizer
https://edinburgh-genome-foundry.github.io/DnaChisel/
MIT License
219 stars 40 forks source link

Uniquify all kmers when include_reverse_complement=False #50

Closed seanrj-conagen closed 3 years ago

seanrj-conagen commented 3 years ago

It crashes due to: UnboundLocalError: local variable 'L' referenced before assignment Can be fixed by moving: https://github.com/Edinburgh-Genome-Foundry/DnaChisel/blob/726b2b0254a8dbd9f51a78998cbb4e43cb096057/dnachisel/builtin_specifications/UniquifyAllKmers.py#L43

To above the if statement.

lebolo commented 3 years ago

Hi @seanrj-conagen, just FYI, @sukolsak opened PR #49 to fix this (and it was merged in)

seanrj-conagen commented 3 years ago

ok, thanks, I should just update. I must have an old version.

lebolo commented 3 years ago

Oh, his PR hasn't been released yet, just merged to develop (sorry, I'm just a nosy contributor, not a maintainer of this repo hehe)

seanrj-conagen commented 3 years ago

Oh, I see, that's funny, he saw the issue the same day!

veghp commented 3 years ago

Thanks -- now fixed in the latest release