Closed MrTomRod closed 3 years ago
My two cents: the GraphicFeature's primary parameters all refer to graphic properties ("what you will see") and the locus_tag parameter, if it is not used for graphical display, would be an outlier. If you simply don't add the locus_tag as a parameter in the definition GraphicFeature (the rest of your code remaining unchanged) the locus_tag would then be interpreted as a **data
component and be accessible via my_feature.data['locus_tag']
.
That makes sense, I didn't study the API closely enough. Thanks!
To clarify, I wasn't suggesting to close the MR, as parts of it like compute_locus_tag
may still be a valid approach. You can re-open this MR if you believe a core change to DFV is best way to solve your problem.
I found locus_tag to be a useful property of GraphicFeature objects because it tends to be unique.