search

Edinburgh-Genome-Foundry / DnaFeaturesViewer

:eye: Python library to plot DNA sequence features (e.g. from Genbank files)
https://edinburgh-genome-foundry.github.io/DnaFeaturesViewer/
MIT License
584 stars 90 forks source link

type hints support #72

Open antonkulaga opened 1 year ago

antonkulaga commented 1 year ago

It would be useful to have type-hints as it allows better reasoning about the code and avoiding some errors

veghp commented 1 year ago

Thanks for the feedback, I agree it may be useful with the size and complexity of some of the packages, but there are some counterarguments in our case: it's a non-trivial undertaking especially if we want to maintain style consistency across the EGF package ecosystem, with no function gain for the user. Therefore this is likely will not be implemented, but will keep open to the idea. Please note that these packages are used in very expensive lab operations, and in other non-EGF packages and companies, therefore we have to be very conservative with the changes.