Edinburgh-Genome-Foundry / DnaFeaturesViewer

:eye: Python library to plot DNA sequence features (e.g. from Genbank files)
https://edinburgh-genome-foundry.github.io/DnaFeaturesViewer/
MIT License
584 stars 90 forks source link

To fix the concatenation error #75

Closed rraadd88 closed 1 year ago

rraadd88 commented 1 year ago

When dna_features_viewer (installed from pypi v3.1.1) was imported, using this command: import dna_features_viewer, it produced concatenation errors:

  1. TypeError: can only concatenate tuple (not "str") to tuple because tuple called aa1 was being concatenated to a string '*', and
  2. TypeError: can only concatenate tuple (not "list") to tuple because tuple called aa3 was being concatenated to a list ['*'].

The suggested modification — where respective tuples and strings are converted to lists before concatenation — should fix these errors.

veghp commented 1 year ago

Thank you for the contribution -- an equivalent solution has been merged that also handles previous Biopython versions.