search

Edinburgh-Genome-Foundry / DnaWeaver

A route planner for DNA assembly
https://dnaweaver.genomefoundry.org
MIT License
29 stars 9 forks source link

Bug: Max length initialisation #8

Open andrewshvv opened 3 years ago

andrewshvv commented 3 years ago

I believe it should be sequence_length + 1 otherwise GoldenGatePartLibrary might be ignored if the whole sequence is from the library.

https://github.com/Edinburgh-Genome-Foundry/DnaWeaver/blob/6a26b08d9571fbaf91ac7058d45ed0706333e05d/dnaweaver/DnaSupplier/builtin_suppliers/DnaAssemblyStation/SequenceDecomposer.py#L124

Because here you make a comparison of this form: https://github.com/Edinburgh-Genome-Foundry/DnaWeaver/blob/6a26b08d9571fbaf91ac7058d45ed0706333e05d/dnaweaver/DnaSupplier/builtin_suppliers/DnaAssemblyStation/SequenceDecomposer.py#L173

Zulko commented 3 years ago

Thanks for reporting this. Can you confirm that the fix you are suggesting is solving your issue? If yes can you open a PR?

andrewshvv commented 3 years ago

Sorry, I thought I have answered.

Yeah, I can confirm it solved the issue, will try to make a PR soon.