search

Edinburgh-Genome-Foundry / blabel

:label: Python label/sticker PDF generation. HTML templates, built-in barcodes, qr codes, and other goodies
https://edinburgh-genome-foundry.github.io/blabel
MIT License
179 stars 38 forks source link

Don't force an specific weasyprint version #19

Closed bellini666 closed 2 years ago

bellini666 commented 2 years ago

Hi,

The last version of this lib started to force weasyprint <= 52 due to the fact that not all GNU/Linux distributions have the latest Pango that is required by the latest WeasyPrint.

Although the reasoning is understandable, I think it is too much for blabel to force that, making it impossible for an app that can run weasyprint >= 53 and requires a newer version to use this lib.

I would suggest adding a note on README that if someone have issues with pango, they should fix their weasyprint installation to <=52 and loose this lib's requirement again.

veghp commented 2 years ago

hi, thanks, yes that's a valid request. Will look into it tomorrow.

bellini666 commented 2 years ago

Thank you! :)