search

EdinburghGenomics / pyclarity-lims

Python interface to the GenoLogics LIMS server via its REST API.
MIT License
11 stars 5 forks source link

Start_index and depagination #33

Closed tcezard closed 6 years ago

tcezard commented 6 years ago

This PR fixes start_index which now only specify the first element return. A new parameter nb_page specify how many pages to return. nb_page=-1 which is default return all pages available from the start_index fixes #32

coveralls commented 6 years ago

Coverage Status

Coverage increased (+1.4%) to 78.706% when pulling f5b602cc77c3394e74a91cb2900bc87842b03a71 on fix_start_index into d73f5b7d76f0d65b4fe51fbc80e4bf9f49903a6c on master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+1.4%) to 78.706% when pulling df7f1f449516f287457a320ec23d7d2b52979c3a on fix_start_index into d73f5b7d76f0d65b4fe51fbc80e4bf9f49903a6c on master.

jonathandixon commented 6 years ago

Setting nb_page to -1 or 0 will return all pages from the start_index, which is fine but maybe it should be documented.

BTW, thank you for this package. It makes working with Clarity LIMS much easier.