EdinburghGenomics / pyclarity-lims

Python interface to the GenoLogics LIMS server via its REST API.
MIT License
11 stars 4 forks source link

Added name attribute to ReagentType. #56

Closed rich7409 closed 3 years ago

rich7409 commented 3 years ago

We needed to get the name of reagent types returned in the ReagentType class. It is there in the XML, it's just been missed from the class. It's just a "name" attribute added to the class.

mwhamgenomics commented 3 years ago

Looks good! Ideally there would be an accompanying test, but ReagentType doesn't currently have any test coverage anyway, and the build doesn't seem to be running anymore since GitHub switched to Actions. I'll accept this, then figure out the build and tests