search

EdinburghNLP / nematus

Open-Source Neural Machine Translation in Tensorflow
BSD 3-Clause "New" or "Revised" License
797 stars 269 forks source link

nematus/server directory deleted during TF merge, breaking server.py #77

Closed StanczakDominik closed 5 years ago

StanczakDominik commented 6 years ago

After the 9b1ebb5f5937a52081ad66ebd525a1e476883834 merge, on a fresh install, nematus/server.py is going to crash since these two lines

https://github.com/EdinburghNLP/nematus/blob/5727727c5b9efa53e249cb0c84114acabf384b5d/nematus/server.py#L15-L16

refer to the now-deleted server directory. I've figured out a way to revert that using PyCharm (I'm not enough of a git wizard to do it "by hand", I guess :smile:) that conserves the files' git history using git log --full-history (my test commit is the only one I see via the usual git log nematus/server), which I can submit as a PR if you'd like.

Also, :tada: for TF and Python 3 compatibility!

rsennrich commented 6 years ago

Hi Dominik,

thanks for the report; I've now restored nematus/server in the master branch; I'd be glad if you could test the server functionality.

StanczakDominik commented 6 years ago

Thank you! Will do! :)