search

Edirom / Edirom-Online

Edirom Online is a tool for presenting historical-critical music editions in digital form.
GNU General Public License v3.0
19 stars 18 forks source link

annotationView single forward/backward #116

Open bwbohl opened 6 years ago

bwbohl commented 6 years ago

The AnnotationView offers three view modes for annotation participants:

  1. grid
  2. single
  3. list

Using digilib as an image server, when switching to singleView the backward and forward icons to flip through the facsimiles fail to load. Tries to load from /exist/apps/EdiromOnline/pix/annotPreviewForward.png

Using leaflet as an image server, when switching to singleView, loading backwards and forwardPNGs is not even triggered.

bwbohl commented 2 months ago

Also with digilib IIIF image-server the icons are not present. You can see that the should be there if you inspect the HTML:

<div class="annotView">
    <div class="previewArea">
        <div class="previewItem widthLimited" id="ext-gen6106" style="width: 100%; height: 100%;">
<!-- HERE -->
            <div class="stepLeft"></div>
            <div class="stepRight"></div>
<!-- HERE -->
            <div class="imgBox" id="ext-gen6107">
                <img src="[OMITTED]" class="previewImg">
                <input type="hidden" class="previewImgData" value="[object Object]" id="ext-gen6108">
            </div>
            <div class="label">null: Takte&nbsp;1&nbsp;bis&nbsp;14</div>
        </div>
    </div>
</div>
bwbohl commented 2 months ago

Apparently, the div:s are hidden via CSS with display:none;. Changing this makes them visible, but they don’t seem to have a functionality implemented.

They are created in https://github.com/Edirom/Edirom-Online/blob/78d4d323a5f3c817a41b97bcbc0896e75b1b3d09/app/view/window/AnnotationView.js#L652-L659

Styling is done in https://github.com/Edirom/Edirom-Online/blob/78d4d323a5f3c817a41b97bcbc0896e75b1b3d09/packages/eoTheme/sass/etc/annotation.scss#L323-L345

The presence of this functionality doesn’t seem critical to me; consequently, we could also drop it. Opinions @Edirom/edirom-online-developer ?