Edirom / Edirom-Online

Edirom Online is a tool for presenting historical-critical music editions in digital form.
GNU General Public License v3.0
20 stars 24 forks source link

fullwidht apostrophe – Window fails to load #118

Closed bwbohl closed 1 month ago

bwbohl commented 7 years ago

When a fullwidth Apostrophe »'« (U+FF07) is part of the value being evaluated as window title the resource . fails to load

peterstadler commented 1 month ago

can you elaborate a little bit, please? Which XQuery(?) function fails?

bwbohl commented 1 month ago

Apparently this is quite old and probably also connected to #337

By the time I reported these content windows in the Edirom Online GUI failed to load contents and loaded as empty blank windows. All this was because the window title had some unexpected character, e.g. apostrophe (tick) or newline character. Probably normalizing space or even the proper serialization of requests might fix those issues.

peterstadler commented 1 month ago

I could not reproduce the issue. Adding a ' to a titlePart did not break the display.

The MEI code used

<mei xmlns="http://www.music-encoding.org/ns/mei" xmlns:xlink="http://www.w3.org/1999/xlink" meiversion="5.0" xml:id="edirom_source_obert-weberianaI-24">
    <meiHead meiversion="5.0">
        <fileDesc>
            <titleStmt>
                <title type="uniform" xml:lang="de">
                    <titlePart type="main" xml:lang="de">Weberiana Cl' I&#xFF07; 24</titlePart>
                    <titlePart type="perf" xml:lang="de">Die drei Pintos: Einige Takte Autograph</titlePart>
                </title>

The rendering

Bildschirmfoto 2024-09-10 um 16 04 13

Attempt of explanation

Since this is a rather old issue, it probably got fixed in 2012 by ad25d850a6e2eb3e60a54a643e92b3519702a2e0 where the old way of manually returning a string value (return concat( … )) got changed to a proper serialization of a map object (return serialize($map, $options)).

riedde commented 1 month ago

The same for me, I also can't reproduce this. @bwbohl would you share a file with me that produces the fail? Maybe the problem is caused by a different incident.

peterstadler commented 1 month ago

I really do think this issue is outdated and fixed by proper serialization. I propose to close the issue if we do not come up with a reproducible test case in the next week

bwbohl commented 1 month ago

It

The same for me, I also can't reproduce this. @bwbohl would you share a file with me that produces the fail? Maybe the problem is caused by a different incident.

The issue is so 2017 ;-). I really don't think I still have the file lying around. So, I'm +1 for closing this as it is not reproducible.

bwbohl commented 1 month ago

@thx for all your efforts @riedde & @peterstadler