Open riedde opened 1 year ago
@riedde what’s the status of this draft, any chance to resolve conflicts and close TODOs in the near future?
@bwbohl conflicts resolved. I'll have a look at the TODOs
What’s an appropriate dataset for testing this?
@bwbohl e.g., https://klarinettenquintett.weber-gesamtausgabe.de/index.html?lang=de (Erstdruck 1)
Tested with the klarinettenquintett dataset:
The multiRest at the start of the Allegro in D+-st is also missing "–11"
ping @nikobeer
pinging @riedde
@bwbohl I reviewed the function measure:getMeasureLabel()
. It seems that there was an else case missing (added at https://github.com/Edirom/Edirom-Online/pull/302/commits/14837c2761d9d49c583c69571af04e029d7e6a14). I'm not sure if this coveres all cases but it is much more better than before and works with several datasets. I can offer you my dataset for testing if you like (three editions).
While testing I noticed that there is a bug when loading the measure based view with parts. I have to investigate this.
does this also address #432 ?
@bwbohl I don't think that this addresses #432, directly.
Better handling of Measure labels
1/9
)needs: