Edirom / Edirom-Online

Edirom Online is a tool for presenting historical-critical music editions in digital form.
GNU General Public License v3.0
20 stars 24 forks source link

Feature: Auto measure label handling #302

Open riedde opened 1 year ago

riedde commented 1 year ago

Better handling of Measure labels

needs:

bwbohl commented 8 months ago

@riedde what’s the status of this draft, any chance to resolve conflicts and close TODOs in the near future?

riedde commented 8 months ago

@bwbohl conflicts resolved. I'll have a look at the TODOs

bwbohl commented 7 months ago

What’s an appropriate dataset for testing this?

riedde commented 7 months ago

@bwbohl e.g., https://klarinettenquintett.weber-gesamtausgabe.de/index.html?lang=de (Erstdruck 1)

bwbohl commented 7 months ago

Tested with the klarinettenquintett dataset:

bwbohl commented 7 months ago

The multiRest at the start of the Allegro in D+-st is also missing "–11"

krHERO commented 4 months ago

ping @nikobeer

bwbohl commented 3 months ago

pinging @riedde

riedde commented 3 months ago

@bwbohl I reviewed the function measure:getMeasureLabel(). It seems that there was an else case missing (added at https://github.com/Edirom/Edirom-Online/pull/302/commits/14837c2761d9d49c583c69571af04e029d7e6a14). I'm not sure if this coveres all cases but it is much more better than before and works with several datasets. I can offer you my dataset for testing if you like (three editions).

riedde commented 2 weeks ago

While testing I noticed that there is a bug when loading the measure based view with parts. I have to investigate this.

bwbohl commented 4 days ago

does this also address #432 ?

riedde commented 16 hours ago

@bwbohl I don't think that this addresses #432, directly.