search

Edirom / Edirom-Online

Edirom Online is a tool for presenting historical-critical music editions in digital form.
GNU General Public License v3.0
19 stars 18 forks source link

Fix: annotationList and annotationPreview #303

Closed riedde closed 1 year ago

riedde commented 1 year ago

The annotation list didn't show the source sigla because of an outdated xpath (MEI3 and earlier). This PR provides an update for MEI4 and MEI5-dev. Further the annotation preview was broken because of the source:isSource() function. It was just checking manuscripts or sources in MEI3 or older. Now it checks also prints and also later versions, e.g. MEI5-dev using a regex.

Note: Since a manuscript requires <manifestation singleton="true"/>, I added analogously that a print requires <item>.

bwbohl commented 1 year ago

while I really deem these changes good ones, I think maybe we should come up with a central function to get the MEI version and use that in every place that we need a distinction between MEI versions.