search

Edirom / Edirom-Online

Edirom Online is a tool for presenting historical-critical music editions in digital form.
GNU General Public License v3.0
21 stars 25 forks source link

Ace WrapMode in XML View #86

Open nikobeer opened 8 years ago

nikobeer commented 8 years ago

Changing l. 53 in https://github.com/Edirom/Edirom-Online/blob/develop/app/view/window/XmlView.js to this.editor.getSession().setUseWrapMode(true); causes the rendering of (long) the XML-file(s) to stop after a certain amount of lines.

bwbohl commented 3 years ago

is this still the case and please could you elaborate a bit?

krHERO commented 5 months ago

ping @nikobeer

nikobeer commented 5 months ago

I think, this was a problem in the OPERA editions, where XML files could become veeeeery long. As of now, I have no access to a OPERA Edirom to test this.

A short test with RWA data does not show the bug. However, we do not have such big XML files and we actually do not use the XML view.

So, currently there is nothing more to say here…

bwbohl commented 5 months ago

Instead of closing this should probably get a "needs testing" or similar?

nikobeer commented 5 months ago

Ok, @bwbohl please do the appropriate…

bwbohl commented 5 months ago

@daniel-jettka is there already an appropriate label or should we add another status in the project board?

daniel-jettka commented 5 months ago

@daniel-jettka is there already an appropriate label or should we add another status in the project board?

I've seen you assigned the label "Status: needs testing". So that's fine I guess, is it? @bwbohl