search

Edirom / MEIGarage

The MEI Garage is a "workshop" for symbolic music encoding data. It is sharing a code base with the TEI's OxGarage and offers a convenient interface to common tasks for music encoding data, both through Web and REST interfaces. It offers conversion between different formats and customization of the MEI Schema.
https://meigarage.edirom.de/
GNU General Public License v3.0
0 stars 0 forks source link

Create Docker file #6

Closed anneferger closed 3 years ago

anneferger commented 3 years ago

but there are some difficulties to download the artifacts from GitHub:

anneferger commented 3 years ago

See https://github.com/baz-ga/Edirom-Online/issues/8

anneferger commented 3 years ago

Tried out nightly link: https://nightly.link/anneferger/MEIGarage/workflows/maven/main/meigarage.war.zip

anneferger commented 3 years ago

We will use https://nightly.link/ so that no authentication is needed for building the Docker image locally

peterstadler commented 3 years ago

just added the nightly.link app, set up the artifact links and pushed the Dockerfile. Some questions now:

  1. the main REST endpoint of the MEIGarage is now /meigarage/. Do we want this—for historic and compatibility reasons— to be /ege-webservice/? Or do we now want this to be directly under root /?
  2. is LibreOffice needed for the MEIGarage? Getting rid of it would result in a much slimmer image.
  3. where is the log4j configuration? It's referred to at https://github.com/Edirom/MEIGarage/blob/2ddb1fed72b12b3bab67e4cf364a74c4b12c128c/Dockerfile#L52-L53 but not in this repo. Is it save to copy it from https://github.com/TEIC/oxgarage/blob/dev/log4j.xml or is it in some other repo now?
anneferger commented 3 years ago
  1. Yes good point, I'll keep it at /ege-webservice/ for now and if we decide to change it we can discuss that again
  2. I'll have a look if it is really not needed anywhere in MEIGarage
  3. There are two versions of those log configurations in the original repos, I added the respective ones to MEIGarage and TEIGarage
anneferger commented 3 years ago

Should we also rename the artifacts to ege-webservice.war again? Could be helpful to have different names for different functions of the garages.

anneferger commented 3 years ago

1a3f5d50fe065a135b1b9a72fcbdbf293d140f33