search

Edirom / MerMEId

Metadata Editor and Repository for MEI Data
https://mermeid.edirom.de/
Apache License 2.0
12 stars 5 forks source link

replace XML link in the forms top nav #184

Closed peterstadler closed 12 months ago

peterstadler commented 1 year ago

to point at the "raw" MEI file, not the filtered version, implementing #177.

This PR introduces a new parameter in filter/xsl/mermeid_configuration.xsl which can be read by the XForms as instance('parameters')/dcm:view_xml_url_base. The parameter is injected on the XQuery side by modules/transform.xq which is called by the controller at e.g. https://github.com/Edirom/MerMEId/blob/21f7710ece19b8fe5bd1bce1045cab9539f6c0ed/data/controller.xql#L92

peterstadler commented 1 year ago

Thanks for the hint @peterprovaznik , that looks promising and much simpler 👍

peterstadler commented 1 year ago

When eventually merging this PR please squash and merge to get rid of the first attempt and its reversion …

peterstadler commented 12 months ago

I have pulled the issue-177 image, and verified that the unfiltered XML is indeed shown.

(When trying this for one of the sample-files, I noticed two xml-model PIs; these disappeared after making changes, which is most likely is due to PIs not being considered in filter_{get,put}.xsl, so related to #90.)

Thanks for reviewing! I added the PIs to the list at #90 ;)