Edirom / edirom-edition-schema

The schema files for different versions of the edition.xml file used throughout several Edirom versions
1 stars 1 forks source link

add <names> as optional (first) child in <groups> #7

Closed riedde closed 2 years ago

riedde commented 2 years ago

The names section should also be allowed on groups-level. The edirom is able to render it as shown on the attached image.

For now the occurance of //groups/names is invalid.

<concordance name="Edition">
               <names>
                  <name xml:lang="de">Edition</name>
                  <name xml:lang="en">Edition</name>
               </names>
               <groups label="Song">
                  <names>
                     <name xml:lang="de">Lied</name>
                     <name xml:lang="en">Song</name>
                  </names>
                  <group>
                     <names>
                        <name xml:lang="de">Trüber Abschied</name>
                        <name xml:lang="en">Trüber Abschied</name>
                     </names>
                     <connections label="Takt"/>
Bildschirmfoto 2022-01-19 um 12 50 26
bwbohl commented 2 years ago

@riedde thx for bringing it up!

bwbohl commented 2 years ago

I just noticed that groups may contain labels/label (which is an heirloom from v1.2) but as a search in the Edirom Online repo revealed is not processed Edirom Online (https://github.com/Edirom/Edirom-Online/search?q=edirom%3Alabel). So this should be removed at the same time.

bwbohl commented 2 years ago

fixed in 666343b

riedde commented 2 years ago

Just as an example: This could be helpful when edition a work collection of songs and duets. So their genre can be displayed if necessary.

bwbohl commented 2 years ago

Just as an example: This could be helpful when edition a work collection of songs and duets. So their genre can be displayed if necessary.

this example should be added to some documentation somewhere