search

EdisonWangB / pcmanx-gtk2

Automatically exported from code.google.com/p/pcmanx-gtk2
GNU General Public License v2.0
0 stars 0 forks source link

Porting to gtk3 #61

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
And rename to pcmanx for consistency

Original issue reported on code.google.com by wander...@gmail.com on 23 Aug 2012 at 3:43

GoogleCodeExporter commented 8 years ago

Original comment by fourdollars on 28 Aug 2012 at 2:25

GoogleCodeExporter commented 8 years ago

Original comment by fourdollars on 28 Aug 2012 at 2:36

GoogleCodeExporter commented 8 years ago

Original comment by fourdollars on 28 Aug 2012 at 2:38

GoogleCodeExporter commented 8 years ago 
I think we should start from eliminating the usage of Gtk+ deprecated functions.

Original comment by jserv.tw@gmail.com on 28 Aug 2012 at 8:39

GoogleCodeExporter commented 8 years ago 
I removed some GTK+ deprecated functions in pcmanx-gtk2.

Original comment by lantw44 on 8 Nov 2013 at 3:23

Attachments:

GoogleCodeExporter commented 8 years ago 
What a coincident,  I did the similar work yesterday.

Some suggestion :

1. separate your patch by different function change.
ex : patch 1 : handle all  GTK_WIDGET_SET_FLAGS (widget, GTK_CAN_DEFAULT) -> 
gtk_widget_set_can_default(widget, TRUE)
     pathc 2 : GTK_WIDGET_VISIBLE(m_Name) -> gtk_widget_get_visible(m_Name) 

2. gnome has provide a porting guide at 
https://developer.gnome.org/gtk3/stable/gtk-migrating-2-to-3.html 
To add what rule you use to the commit comment make commit reason more clear (I 
think)

Original comment by cmc...@gmail.com on 8 Nov 2013 at 6:06

GoogleCodeExporter commented 8 years ago 
Some work about this issue and they are located in 
https://github.com/cmchao/pcmanx-gtk2

There are two branch, no2,22 and gtk3
https://github.com/cmchao/pcmanx-gtk2/tree/no2.22
https://github.com/cmchao/pcmanx-gtk2/tree/gtk3

no2.22 remove support for GTK version <  2.22 
gtk3 is based on no2.22 and do gtk3 migration by following gtk migrating guide 

If the above work is acceptable,  the last step is to rewrite the gdk with 
cairo.
Need someone to do that ...:P

Original comment by cmc...@gmail.com on 27 Feb 2014 at 4:01

GoogleCodeExporter commented 8 years ago 
Maybe you can put these branches to here:

https://github.com/pcman-bbs/pcmanx

Original comment by wander...@gmail.com on 3 Mar 2014 at 3:05

GoogleCodeExporter commented 8 years ago 
done ..:P

Original comment by cmc...@gmail.com on 13 Mar 2014 at 3:44

GoogleCodeExporter commented 8 years ago 
Great work! I have only one question: how is it going to this project? I mean, 
pcmanx-gtk2 project will be renamed or just kept?

Original comment by jserv.tw@gmail.com on 13 Mar 2014 at 3:48

GoogleCodeExporter commented 8 years ago 
I think that renaming is better, so I create the repo on github.

Original comment by wander...@gmail.com on 13 Mar 2014 at 3:53

GoogleCodeExporter commented 8 years ago 
I prefer moving to https://code.google.com/p/pcmanx/. :P

Original comment by fourdollars on 14 Mar 2014 at 1:59