search

EdisonZhong17 / pe

0 stars 0 forks source link

[BUG] After adding schedule workout for yesterday cannot be listed out. #12

Open EdisonZhong17 opened 2 years ago

EdisonZhong17 commented 2 years ago

image.png Adding schedule workout has issue with storage.

nus-se-bot commented 2 years ago

Team's Response

image.png

The workout is added in a date in the past and is automatically deleted instead of rescheduled in this case since it is counted as overdue. A message was output as a result.

This is an implementation choice to ensure the list stays neat and clean. The implementation is further elaborated in the DG under the ScheduleTracker section. This is an excerpt of the section:

image.png

While scheduling workouts in the past may not be that intuitive, this was decided to be allowed as it has value for recurring workouts. e.g. today is Friday 19/11/21, I want to schedule a recurring workout for next Thursday. I can simply schedule one on 18/11/21 and it will automatically reschedule it to 25/11/21 without having to check next thursday's date. Non-recurring workouts are simply automatically deleted and the user is informed with a message, this would be the same even if the adding the scheduled workout is rejected and an exception is thrown with a relevant message. So it was decided there is more positive's to this implementation.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: [replace this with your explanation]