Edivad99 / SolarGeneration

Produce energy from the sun, use your head for recharging your inventory. This is a mod for minecraft
GNU Affero General Public License v3.0
7 stars 9 forks source link

[1.14.4] Display issue on the client side in the solar panel container with a dedicated server #14

Closed HyCraftHD closed 4 years ago

HyCraftHD commented 4 years ago

The value wrappes around at 32000 into the minus values and up again. grafik

This is due to the trackInt method that casts the integer to a short value: https://github.com/Edivad99/SolarGeneration/blob/38bb3a703bde2f2a82dda4bf4da4cbd1853c2ddd/src/main/java/edivad/solargeneration/blocks/containers/SolarPanelContainer.java#L26-L39

To fix this you must use custom packets like this custom tracker here: https://github.com/MC-U-Team/U-Team-Core/blob/153fd57f88a0d2d71a8f69072f86dc57a89970de/src/main/java/info/u_team/u_team_core/container/UContainer.java#L97-L103

Edivad99 commented 4 years ago

Hi, I tried to look at your code, but since I'm still inexperienced, I can't understand much of it. If you want to help me it would be great.

HyCraftHD commented 4 years ago

No problem. I make a pr soon.

HyCraftHD commented 4 years ago

Done. Your build system seems to bug though

HyCraftHD commented 4 years ago

Thanks fixed with #15