search

EdmundTangg / pe

0 stars 0 forks source link

Inconsistency in number of decimal points taken in for Add command #3

Open EdmundTangg opened 2 months ago

EdmundTangg commented 2 months ago

As seen, I tried to enter a price value with 9 decimal points. However, the program only displayed 2 decimal points.

The UG did not mention any constrains regarding the price that I can input.

image.png

nus-pe-script commented 2 months ago

Team's Response

Simulating real life situations where buy and selling price takes up to 2d.p. However, it could have been more clearly stated in the UG

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Inconsistency in number of decimal points taken in for overall commands, and those displayed

For each command that involves numbers the UG does not say about the decimal points that can be input. There is a lack of consistency between features and as a user, I am confused on the accuracy of numbers that I can insert and will be displayed.

list_items command displays 2dp.

image.png

total_revenue command displays 1dp.

image.png

[original: nus-cs2113-AY2324S2/pe-interim#2547] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Does not impact if 2 decimal place is required for total_revenue

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** I disagree with the response "Does not impact if 2 decimal place is required for total_revenue". Different commands are displaying different number of decimal points, which is a consistency issue that can throw the user off. The user can enter any number of decimal points in the add command, but when displayed in total_revenue for example, it only displays up till a maximum of 2. ![image.png](https://raw.githubusercontent.com/EdmundTangg/pe/main/files/82bd2365-c91a-4c31-abe6-d60417e0cb15.png) I stand on my ground as this being a bug, definitely not [response.NotInScope].
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** This is a serious bug. 1. UG did not say how many decimal points can be entered. User is unaware of the decimal points that can be entered, thus it is assumed that user can enter any amount. User then proceeds to enter any amount, yet confronted with different parsing ability of different commands. As a user, this causes occasional inconvenience to me. I stand on my ground as this being a [severity.Medium].