search

Edo-kawa / SE-Project

1 stars 1 forks source link

Code refactoring issue #3

Open bardzjhe opened 2 years ago

bardzjhe commented 2 years ago

cc. @gzlzgzl

Greetings! Thank you for your efforts. Here are some suggestions for the chess class.

How about let's Integrate x, y into a class called location? It is not meaningless, cause we can try to put operations on vertical/horizontal displacement there, and some other arithmetic operations there and in a move class. Do you think it can improve readability? refer to 1. https://github.com/zli117/Chess-Game/blob/master/src/main/java/utils/Location.java

  1. https://github.com/zli117/Chess-Game/blob/master/src/main/java/utils/Move.java

Welcome to discuss here :D

Cheers! Anthony

gzlzgzl commented 2 years ago

will consider, but please let me finish before that.