Edo-kawa / SE-Project

1 stars 1 forks source link

To-do list #5

Open bardzjhe opened 1 year ago

bardzjhe commented 1 year ago

cc. @melody777k @gzlzgzl Hey dudes,

Greetings!

It's acknowledged that almost all of us don't really have time for going through all commits. Please list tasks here, and so that we can polish the program here. Or if you have any brand new ideas, feel free to share here.

Cheers :D

bardzjhe commented 1 year ago

If you input the chess that has been taken, there will be some exceptions.

bardzjhe commented 1 year ago

For the controller, play_turn fails to align with player_1, and player_2.

bardzjhe commented 1 year ago

Hi, @gzlzgzl, do you think it's fine? I mean why the initial condition i is max. Line 153, ChessBoard class. image

gzlzgzl commented 1 year ago

go ahead, just make sure there's no bugs

gzlzgzl commented 1 year ago

just change it

bardzjhe commented 1 year ago

Dear @Edo-kawa please refer to https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/exploring-the-dependencies-of-a-repository#viewing-the-dependency-graph to enable dependency graph. You are the admin with this kind of authority. Thanks!

Edo-kawa commented 1 year ago

Enabled already. Creating a security update for junit currently.

寄件者: Anthony Hefferon @.> 日期: 星期日, 2022年11月13日 21:08 收件者: Edo-kawa/SE-Project @.> 副本: EdwardYip @.>, Mention @.> 主旨: Re: [Edo-kawa/SE-Project] To-do list (Issue #5)

Dear @Edo-kawahttps://github.com/Edo-kawa please refer to https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/exploring-the-dependencies-of-a-repository#viewing-the-dependency-graph to enable dependency graph. You are the admin with this kind of authority. Thanks!

— Reply to this email directly, view it on GitHubhttps://github.com/Edo-kawa/SE-Project/issues/5#issuecomment-1312726912, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARDQDB3MJ5S2UIYLKPEWY6DWIDR4NANCNFSM6AAAAAARJEBCX4. You are receiving this because you were mentioned.Message ID: @.***>