search

EdoanR / controls-for-yt-shorts

A chrome extension that add video controls for YouTube Shorts.
https://chromewebstore.google.com/detail/daocpklojfnjgomjaemhhibodkpcjlpe
MIT License
6 stars 3 forks source link

Clicking the video is registered as double click, so it won't pause or play #2

Closed yusufsaid71 closed 3 days ago

yusufsaid71 commented 6 months ago

I am recently having a issue where clicking a short video will not pause the video. It will receive it as a double click, so it continuous playing (after a very brief pause). Same when the video is on pause, it will continue being paused (after playing very briefly). Regular play/pause buttons, or keyboard space button works fine. The problem goes away when I disable this extension. Can we have a fix for it?

EdoanR commented 6 months ago

Hi, unfortunately I'm not being able to reproduce the problem on my end. Can you answer some questions so I can investigate further?

  1. what browser are you using?
  2. are you using the latest version of the extension? (v1.3.46)
  3. is there other extensions enabled that might interact with YouTube? which ones?
  4. has there been any recent changes to the layout of YouTube since you noticed this problem?
  5. is the issue persistent, meaning does it always happen or just sometimes?
  6. could you provide detailed steps to reproduce the issue starting from when the page is loaded?

Once I have this information, I will do my best to fix this issue. Thank you for the feedback!

yusufsaid71 commented 6 months ago

I tried disabling all extensions other than YT short controls, and enabling them one by one. The issue happens when this extension is enabled: https://chromewebstore.google.com/detail/blocksite-block-websites/eiimnmioipafcokbfikbljfdeojpcgbh

  1. I am on Chrome Version 124.0.6367.119 (Official Build) (64-bit)
  2. Latest version of the extension (v1.3.46)
  3. Answered above. BlockSite extension is somehow interfering, even when Youtube is not on block list
  4. No
  5. The issue is persistent. It will happen every time as long as these two extensions are enabled together
  6. I guess installing both extensions and clicking on a short video should work
EdoanR commented 6 months ago

So it seems that this specific extension is interfering in some way with the video behavior, which is weird since BlockSite doesn't seem to interact that much with the page. I have installed BlockSite but I still couldn't reproduce the problem :/

I tried changing a little bit of both extensions settings but nothing happened. I think there's something very specific to your environment that may be causing the problem.

Is there any specific settings enabled in BlockSite that could be relevant? Or maybe in the browser?

If possible, could you capture a screenshot or screen recording of the issue occurring? Preferably with the console opened (Ctrl+Shift+J on Windows/Linux, Cmd+Option+J on macOS), so I can see if any relevant error or warning message could pop up. This will help me visualize the problem and better understand what you're experiencing.

Thank you.

yusufsaid71 commented 6 months ago

I tried it with my other two computers and cannot replicate the issue there. It is only on my work laptop. It might be that one of the monitoring software they use is interfering with the page. I opened the console and recorded the error message popping up. These messages starting with "GET" are registered a few seconds after I click the video (and it double clicks). They are not registered every time, only once in a while. But if I stop clicking the video and keep scrolling without clicking, I don't get these warnings. 

   GET https://www.youtube.com/pagead/viewthroughconversion/962985656/?backend=innertube&cname=1&cver=2_20240506&foc_id=xgAuX3XZROujMmGphN_scA&label=followon_view&ptype=no_rmkt&random=682653700 net::ERR_BLOCKED_BY_CLIENT

Jpa @ base.js:1975 (anonymous) @ base.js:1981 acb @ base.js:6834 (anonymous) @ base.js:6921 (anonymous) @ base.js:8830 b0 @ base.js:6921 Ccb @ base.js:6917 (anonymous) @ base.js:12685 (anonymous) @ base.js:12692 Eeb @ base.js:7187 (anonymous) @ base.js:12886 (anonymous) @ base.js:12873 (anonymous) @ base.js:1941 Ed @ base.js:306 (anonymous) @ base.js:7999 (anonymous) @ base.js:9781 (anonymous) @ base.js:5213 base.js:1975 

   GET https://www.youtube.com/pagead/viewthroughconversion/962985656/?backend=innertube&cname=1&cver=2_20240506&foc_id=rMabu7HclTiDf5ZAgjHxqQ&label=followon_view&ptype=no_rmkt&random=651044696 net::ERR_BLOCKED_BY_CLIENT

Jpa @ base.js:1975 (anonymous) @ base.js:1981 acb @ base.js:6834 (anonymous) @ base.js:6921 (anonymous) @ base.js:8830 b0 @ base.js:6921 Ccb @ base.js:6917 (anonymous) @ base.js:12685 (anonymous) @ base.js:12692 Eeb @ base.js:7187 (anonymous) @ base.js:12886 (anonymous) @ base.js:12873 (anonymous) @ base.js:1941 Ed @ base.js:306 (anonymous) @ base.js:7999 (anonymous) @ base.js:9781 (anonymous) @ base.js:5213 jOLX7d5agxw:1 Uncaught (in promise) Error: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received jOLX7d5agxw:1 Uncaught (in promise) Error: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received (This last line is repeated way too many times, so I deleted the excessive ones.)

   GET https://www.youtube.com/pagead/viewthroughconversion/962985656/?backend=innertube&cname=1&cver=2_20240506&foc_id=NwxZoU9bBq-UI3viJZ84FQ&label=followon_view&ptype=no_rmkt&random=665806744 net::ERR_BLOCKED_BY_CLIENT

Jpa @ base.js:1975 (anonymous) @ base.js:1981 acb @ base.js:6834 (anonymous) @ base.js:6921 (anonymous) @ base.js:8830 b0 @ base.js:6921 Ccb @ base.js:6917 (anonymous) @ base.js:12685 (anonymous) @ base.js:12692 Eeb @ base.js:7187 (anonymous) @ base.js:12886 (anonymous) @ base.js:12873 (anonymous) @ base.js:1941 Ed @ base.js:306 (anonymous) @ base.js:7999 (anonymous) @ base.js:9781 (anonymous) @ base.js:5213 base.js:1975 

   GET https://www.youtube.com/pagead/viewthroughconversion/962985656/?backend=innertube&cname=1&cver=2_20240506&foc_id=G5qGWdu8nIRZqJ_GgDwQ-w&label=followon_view&ptype=no_rmkt&random=465356815 net::ERR_BLOCKED_BY_CLIENT

Jpa @ base.js:1975 (anonymous) @ base.js:1981 acb @ base.js:6834 (anonymous) @ base.js:6921 (anonymous) @ base.js:8830 b0 @ base.js:6921 Ccb @ base.js:6917 (anonymous) @ base.js:12685 (anonymous) @ base.js:12692 Eeb @ base.js:7187 (anonymous) @ base.js:12886 (anonymous) @ base.js:12873 (anonymous) @ base.js:1941 Ed @ base.js:306 (anonymous) @ base.js:7999 (anonymous) @ base.js:9781 (anonymous) @ base.js:5213 base.js:1975 

   GET https://www.youtube.com/pagead/viewthroughconversion/962985656/?backend=innertube&cname=1&cver=2_20240506&foc_id=ESn71WJ_PoaFNGoT-LFRhA&label=followon_view&ptype=no_rmkt&random=168191180 net::ERR_BLOCKED_BY_CLIENT

Jpa @ base.js:1975 (anonymous) @ base.js:1981 acb @ base.js:6834 (anonymous) @ base.js:6921 (anonymous) @ base.js:8830 b0 @ base.js:6921 Ccb @ base.js:6917 (anonymous) @ base.js:12685 (anonymous) @ base.js:12692 Eeb @ base.js:7187 (anonymous) @ base.js:12886 (anonymous) @ base.js:12873 (anonymous) @ base.js:1941 Ed @ base.js:306 (anonymous) @ base.js:7999 (anonymous) @ base.js:9781 (anonymous) @ base.js:5213

EdoanR commented 6 months ago

Sorry for the late response.

Very interesting info, from what I found, the base.js is a script run by YouTube, most of the information of it isn't very useful unfortunately, but what caught my eyes is the following line:

jOLX7d5agxw:1 Uncaught (in promise) Error: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received

Not sure where the jOLX7d5agxw is from, whether it's from YouTube or some of the extensions.

I think the useful messages will only popup in the exact moment where the problem occur (in this case when you click), I don't think what happens before or later will be very relevant for our problem.

Can you answer some questions?

yusufsaid71 commented 6 months ago

Hi, thanks for the response!

The moment I click, I don't see any messages popping up on the console. It happens a few seconds after, and not even after every click.

Answer to your questions:

I understand the issue is rare and only happens with some odd combination. If you don't want to spend time on it I understand. But if you would like to solve it I am happy to help. Thanks for the effort!

vlakoff commented 2 months ago

I am also encountering this issue. I thought that everyone was encountering it, and I am surprised that it's not the case actually.

EdoanR commented 1 month ago

Interesting, probably has something to do with the click event in the video itself. I think other extensions might be irrelevant in this case.

I will test it further to see what might be going on.

Thank your for the feedback!

EdoanR commented 3 weeks ago

Hey guys, I updated the extension to version 2.0.0 recently that made a lot of changes in how the player works, I'm wondering if the problem is still happening, please let me know. Thank you

yusufsaid71 commented 3 weeks ago

Looks like the extension is removed from Google extension store. It says "This item is not available".

EdoanR commented 3 weeks ago

@yusufsaid71 that's odd. Try this link: https://chromewebstore.google.com/detail/daocpklojfnjgomjaemhhibodkpcjlpe

yusufsaid71 commented 3 weeks ago

Nope, it doesn't work. Both my phone and laptop say the item is not available. Incognito mode too.

On Thu, Oct 17, 2024 at 2:19 PM Edoan @.***> wrote:

@yusufsaid71 https://github.com/yusufsaid71 that's odd. Try this link: https://chromewebstore.google.com/detail/daocpklojfnjgomjaemhhibodkpcjlpe

— Reply to this email directly, view it on GitHub https://github.com/EdoanR/controls-for-yt-shorts/issues/2#issuecomment-2420231097, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJUP6IKXPCKRO5THLDI6RB3Z375RXAVCNFSM6AAAAABHJTDFDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRQGIZTCMBZG4 . You are receiving this because you were mentioned.Message ID: @.***>

-- Yusuf Said EROĞLU

EdoanR commented 3 weeks ago

@yusufsaid71 it's working on my end, What region/country are you from?

yusufsaid71 commented 3 weeks ago

United States

On Fri, Oct 18, 2024, 3:50 PM Edoan @.***> wrote:

@yusufsaid71 https://github.com/yusufsaid71 it's working on my end, What region/country are you from?

— Reply to this email directly, view it on GitHub https://github.com/EdoanR/controls-for-yt-shorts/issues/2#issuecomment-2423134863, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJUP6IOI5VKAHU4DUSEIICLZ4FRBNAVCNFSM6AAAAABHJTDFDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTGEZTIOBWGM . You are receiving this because you were mentioned.Message ID: @.***>

vlakoff commented 3 weeks ago

It also works on my end (France).

@yusufsaid71 If you are still encountering that issue, could you please open a dedicated ticket to continue the discussion, as it is unrelated to the issue of this ticket?

vlakoff commented 3 weeks ago

Back to the issue at hand, I tried again (having version 2.0.0 installed), and the clicks on the video work as expected. 😀 I can't tell if it has been fixed by version 2.0.0 or by a previous version (but I guess it is 2.0.0)

Another problem though: when hovering over the video to show the controls, they tend to slide up/down in the wrong direction, as if some "hover in/out" callback got confused. I workarounded the issue by enabling "Controls always visible" (which is also a fine mode to me). Again, I can't tell if it is a regression from 2.0.0 or a previous version; but it was definitely working better previously.

vlakoff commented 4 days ago

Another problem though: when hovering over the video to show the controls, they tend to slide up/down in the wrong direction, as if some "hover in/out" callback got confused. I workarounded the issue by enabling "Controls always visible" (which is also a fine mode to me). Again, I can't tell if it is a regression from 2.0.0 or a previous version; but it was definitely working better previously.

I have just noticed https://github.com/EdoanR/controls-for-yt-shorts/commit/2ffbdbd8a1b1a9a3d62260b0335c7917311300f9, and tried version 2.0.1: it seems to work perfectly now, great job. 👍

Given that the initial issue and the other concerns have been resolved, I would suggest closing this ticket.

EdoanR commented 3 days ago

I have just noticed 2ffbdbd, and tried version 2.0.1: it seems to work perfectly now, great job. 👍

Given that the initial issue and the other concerns have been resolved, I would suggest closing this ticket.

Nice! YouTube sometimes changes things and break the extension lol. Everything seems to be fine, I gonna close the issue. Any other problem feel free to open a new one :)