search

EdsonBueno / infinite_scroll_pagination

Flutter package to help you lazily load and display pages of items as the user scrolls down your screen.
https://pub.dev/packages/infinite_scroll_pagination
MIT License
605 stars 201 forks source link

feat: Add `paged_masonry_silver_grid_view` #313

Closed mbfakourii closed 4 months ago

mbfakourii commented 4 months ago

Add paged_masonry_silver_grid_view.dart. Add beer_masonry_sliver_grid.dart for example. And Upgrade dependency's.

mbfakourii commented 4 months ago

cc @EdsonBueno to review.

clragon commented 4 months ago

This PR is somewhat of a duplicate of #252. In #252 we have additional resturcting where we remove redundant code in the paged_masonry_grid by using paged_masonry_slider_grid inside of it, much like all other versions. We also made paged_masonry_grid_view a boxview which is consistent with all other view widgets. Additioally, this PR neglects the naming rule for sliver grids which never end in "view". I would recommend merging #252 and upgrading depencencies separately. It is good that this PR includes a sample, however, the repository already has a sample for paged_masonry_grid which in #252 is just a small wrapper around the sliver widget, so I am not sure if this is necessary.

clragon commented 4 months ago

closing this in favour of #252