search

EduardoKrausME / moodle-local-kopere_dashboard

Dashboard Moodle
https://www.eduardokraus.com/kopere-dashboard
26 stars 20 forks source link

Large number displayed has wrong thousands separator #2

Closed germanvaleroelizondo closed 6 years ago

germanvaleroelizondo commented 6 years ago

screen shot 2017-11-23 at 19 58 38 While trying the local kopere dashboard, the number shown in the Users/Assets red coloured box for my University (Moodle 3.2) server is shown as 12.692 / 8.483

But in my country (Mexico) the thousands separator is a comma not a point. This point as a thousands separator would be OK for Spain, but it is wrong for many Moodle sites that use a decimal separator (most of the word).

The number shown here should use the thousands separator defined by the language pack as seen in https://docs.moodle.org/dev/Translation_langconfig#thousandssep.2Ccore_langconfig

Thanks in advance for your help.

eduardokraus commented 6 years ago

https://github.com/EduardoKrausME/moodle-local-kopere_dashboard/commit/e8f518773fd27b63b2c652db299a1f93cb8a3392

germanvaleroelizondo commented 6 years ago

Thanks a lot Eduardo :)