search

EduardoKrausME / moodle-mod_certificatebeautiful

1 stars 2 forks source link

Classname was being extended in the same name #6

Closed purnendudash closed 8 months ago

purnendudash commented 9 months ago

https://github.com/EduardoKrausME/moodle-mod_certificatebeautiful/blob/55c90966d8e638e04288206f7175775754e4e888/classes/event/course_module_viewed.php#L37

eduardokraus commented 9 months ago

Dear Purnendu Dash,

This is a practice that is present in all plugins.

Captura de Tela 2024-02-19 às 11 32 34

Captura de Tela 2024-02-19 às 11 32 46

Captura de Tela 2024-02-19 às 11 33 22

eduardokraus commented 8 months ago

https://github.com/EduardoKrausME/moodle-mod_certificatebeautiful/commit/ee9d7a5a6bf90aa113b08b78a749a473f1eab863

mudrd8mz commented 8 months ago

For the record, I don't think this was necessary. As Eduardo says, it is common to do this in namespaced classes.

purnendudash commented 8 months ago

@mudrd8mz thanks and noted.